Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5783006: Cleanup: Remove unneeded includes of notification_service.h in other headers.... (Closed)

Created:
10 years ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, brettw-cc_chromium.org, cbentzel+watch_chromium.org, Aaron Boodman, pam+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Cleanup: Remove unneeded includes of notification_service.h in other headers. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69321

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -26 lines) Patch
M chrome/browser/chromeos/notifications/balloon_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/notification_panel.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/options/language_config_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_window.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_menu_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_metrics_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/history/top_sites.h View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/net/gaia/token_service_unittest.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/theme_install_bubble_view.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/theme_install_bubble_view.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/theme_install_bubble_view.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/theme_install_bubble_view.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/live_sync/live_sessions_sync_test.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/test_notification_tracker.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/test_notification_tracker.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/thread_observer_helper.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
One cleanup CL a day keeps the doctor away?
10 years ago (2010-12-14 23:36:41 UTC) #1
Elliot Glaysher
10 years ago (2010-12-14 23:40:13 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698