Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 5783001: Add support to pushing unstable changes for the chrome pfq. (Closed)

Created:
10 years ago by sosa
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add support to pushing unstable changes for the chrome pfq. This specifically gets the pfq one step closer to being completely ready to rev. We add --noprebuilts for the chrome pfq as its not ready to host prebuilts and instead we push unstable ebuilds. Anush noticed an Anush today where we are revving even when we don't change, and I've addressed this also in this CL. Specifically: 1) Sort in cbuildbot long options by long format 2) Add --noprebuilts so that the Chrome PFQ can use this for now. 3) Fixed a unittest that had broken in a previous CL for cros_mark_chrome_as_stable. 4) Add ability for chrome to only rev if something really has changed: -- This means, if the new ebuild either: -- doesn't have the exact same chrome_version -- or diff -Bu (actual diff) between last ebuild and new ebuild isn't the same (i.e. detecting a 9999 change or different CROS_SVN_COMMIT) Change-Id: I9b289c2168d6868299573f5d7c7a676380ee497e BUG=chromium-os:8693 TEST=Ran unittests (cbuildbot, cros_mark_*) and ran cbuildbot with new chrome pfq items. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d8a0a57

Patch Set 1 #

Patch Set 2 : Remove prebuilt logic #

Patch Set 3 : keywords #

Patch Set 4 : Fix logic to only update when something has changed." #

Patch Set 5 : Fix unittests #

Total comments: 2

Patch Set 6 : Nit #

Patch Set 7 : Sanity check after sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -43 lines) Patch
M bin/cbuildbot.py View 1 2 3 4 5 6 5 chunks +16 lines, -9 lines 0 comments Download
M bin/cros_mark_chrome_as_stable.py View 1 2 3 4 5 8 chunks +38 lines, -26 lines 0 comments Download
M bin/cros_mark_chrome_as_stable_unittest.py View 1 2 3 4 3 chunks +7 lines, -6 lines 0 comments Download
M cros_mark_as_stable.py View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sosa
anush/cmasone for cros_mark_chrome_* changes. david for cbuildbot and cros_mark_as_stable change.
10 years ago (2010-12-10 06:06:02 UTC) #1
Chris Masone
parts I was to review lgtm http://codereview.chromium.org/5783001/diff/8001/bin/cros_mark_chrome_as_stable.py File bin/cros_mark_chrome_as_stable.py (right): http://codereview.chromium.org/5783001/diff/8001/bin/cros_mark_chrome_as_stable.py#newcode266 bin/cros_mark_chrome_as_stable.py:266: make_stable=False) Is this ...
10 years ago (2010-12-10 16:31:23 UTC) #2
sosa
Hey scott can you take a look at the cbuildbot changes?
10 years ago (2010-12-10 23:44:07 UTC) #3
davidjames
LGTM for cbuildbot and cros_mark_as_stable change.
10 years ago (2010-12-10 23:52:38 UTC) #4
scottz
10 years ago (2010-12-11 00:05:36 UTC) #5
LGTM

http://codereview.chromium.org/5783001/diff/8001/bin/cros_mark_chrome_as_stab...
File bin/cros_mark_chrome_as_stable.py (right):

http://codereview.chromium.org/5783001/diff/8001/bin/cros_mark_chrome_as_stab...
bin/cros_mark_chrome_as_stable.py:272: redirect_stdout=True,
redirect_ should be aligned with exit_code.

Powered by Google App Engine
This is Rietveld 408576698