Issue 5781010: Addresses some performance regression in the GenericBinaryOpStub on ARM followin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5781010: Addresses some performance regression in the GenericBinaryOpStub on ARM followin... (Closed)

Created:
10 years ago by Rodolph Perfetta

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Addresses some performance regression in the GenericBinaryOpStub on ARM following Crankshaft introduction. BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=6146

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -4 lines)			Patch
M	src/arm/code-stubs-arm.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	2 chunks	+6 lines, -3 lines	1 comment	Download
M	src/arm/full-codegen-arm.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/5781010/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/5781010/diff/1/src/arm/code-stubs-arm.cc#newcode1243 src/arm/code-stubs-arm.cc:1243: Wouldn't it be more readable to have an ...

10 years ago (2010-12-17 10:28:38 UTC) #2

Søren Thygesen Gjesse

On 2010/12/17 10:28:38, Søren Gjesse wrote: > LGTM > > http://codereview.chromium.org/5781010/diff/1/src/arm/code-stubs-arm.cc > File src/arm/code-stubs-arm.cc (right): ...

9 years, 11 months ago (2011-01-03 13:59:44 UTC) #3

Søren Thygesen Gjesse

9 years, 11 months ago (2011-01-04 11:04:07 UTC) #4

Committed: http://code.google.com/p/v8/source/detail?r=6146

Thank you for the patch

Expand Messages | Collapse Messages