Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 5781008: Fix assignment compilation bug on ARM and x64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge/build/ia32
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1397 matching lines...) Expand 10 before | Expand all | Expand 10 after
1408 } 1408 }
1409 1409
1410 // Record source position before possible IC call. 1410 // Record source position before possible IC call.
1411 SetSourcePosition(expr->position()); 1411 SetSourcePosition(expr->position());
1412 1412
1413 // Store the value. 1413 // Store the value.
1414 switch (assign_type) { 1414 switch (assign_type) {
1415 case VARIABLE: 1415 case VARIABLE:
1416 EmitVariableAssignment(expr->target()->AsVariableProxy()->var(), 1416 EmitVariableAssignment(expr->target()->AsVariableProxy()->var(),
1417 expr->op()); 1417 expr->op());
1418 context()->Plug(rax);
1418 break; 1419 break;
1419 case NAMED_PROPERTY: 1420 case NAMED_PROPERTY:
1420 EmitNamedPropertyAssignment(expr); 1421 EmitNamedPropertyAssignment(expr);
1421 break; 1422 break;
1422 case KEYED_PROPERTY: 1423 case KEYED_PROPERTY:
1423 EmitKeyedPropertyAssignment(expr); 1424 EmitKeyedPropertyAssignment(expr);
1424 break; 1425 break;
1425 } 1426 }
1426 } 1427 }
1427 1428
(...skipping 2087 matching lines...) Expand 10 before | Expand all | Expand 10 after
3515 __ ret(0); 3516 __ ret(0);
3516 } 3517 }
3517 3518
3518 3519
3519 #undef __ 3520 #undef __
3520 3521
3521 3522
3522 } } // namespace v8::internal 3523 } } // namespace v8::internal
3523 3524
3524 #endif // V8_TARGET_ARCH_X64 3525 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698