Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 5781008: Fix assignment compilation bug on ARM and x64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge/build/ia32
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1471 matching lines...) Expand 10 before | Expand all | Expand 10 after
1482 } 1482 }
1483 1483
1484 // Record source position before possible IC call. 1484 // Record source position before possible IC call.
1485 SetSourcePosition(expr->position()); 1485 SetSourcePosition(expr->position());
1486 1486
1487 // Store the value. 1487 // Store the value.
1488 switch (assign_type) { 1488 switch (assign_type) {
1489 case VARIABLE: 1489 case VARIABLE:
1490 EmitVariableAssignment(expr->target()->AsVariableProxy()->var(), 1490 EmitVariableAssignment(expr->target()->AsVariableProxy()->var(),
1491 expr->op()); 1491 expr->op());
1492 PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);
1493 context()->Plug(r0);
1492 break; 1494 break;
1493 case NAMED_PROPERTY: 1495 case NAMED_PROPERTY:
1494 EmitNamedPropertyAssignment(expr); 1496 EmitNamedPropertyAssignment(expr);
1495 break; 1497 break;
1496 case KEYED_PROPERTY: 1498 case KEYED_PROPERTY:
1497 EmitKeyedPropertyAssignment(expr); 1499 EmitKeyedPropertyAssignment(expr);
1498 break; 1500 break;
1499 } 1501 }
1500 } 1502 }
1501 1503
(...skipping 2087 matching lines...) Expand 10 before | Expand all | Expand 10 after
3589 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value. 3591 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value.
3590 __ add(pc, r1, Operand(masm_->CodeObject())); 3592 __ add(pc, r1, Operand(masm_->CodeObject()));
3591 } 3593 }
3592 3594
3593 3595
3594 #undef __ 3596 #undef __
3595 3597
3596 } } // namespace v8::internal 3598 } } // namespace v8::internal
3597 3599
3598 #endif // V8_TARGET_ARCH_ARM 3600 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698