Fix pyauto downloads tests to trigger dangerous downloads to match expectation

Fix pyauto downloads tests to trigger dangerous downloads to match expectation

It used to be possible to navigate to a dnagerous file type to trigger its
download. Not anymore. Now all downloads where the user initiated it (by
navigating to a URL or clicking on a link) are not marked unsafe even for
unsafe filetypes.

Update the tests to trigger dangerous downloads by navigating to a file which
in turn triggers the dangerous files to download.

BUG=66081, 57875
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69093

[kkania, 2010-12-14 00:50:43]

http://codereview.chromium.org/5781006/diff/2001/chrome/test/functional/downl...
File chrome/test/functional/downloads.py (right):

http://codereview.chromium.org/5781006/diff/2001/chrome/test/functional/downl...
chrome/test/functional/downloads.py:314: Waits until the download starts.
Maybe mention that this navigates the current page?

http://codereview.chromium.org/5781006/diff/2001/chrome/test/functional/downl...
chrome/test/functional/downloads.py:318: This should exist in the 'dangerous'
directory.
how about change this to take an absolute path (which GetDangerousDownload
returns), or change GetDangerousDownload to get the relative path? That way you
don't have to do os.path.basename.

http://codereview.chromium.org/5781006/diff/2001/chrome/test/functional/downl...
chrome/test/functional/downloads.py:328: self.NavigateToURL(file_url, windex,
tab_index)
Instead of creating the new html page just for redirect, how about just execute
the javascript window.location = ... in the current page?

[Nirnimesh, 2010-12-14 01:05:21]

http://codereview.chromium.org/5781006/diff/2001/chrome/test/functional/downl...
File chrome/test/functional/downloads.py (right):

http://codereview.chromium.org/5781006/diff/2001/chrome/test/functional/downl...
chrome/test/functional/downloads.py:314: Waits until the download starts.
On 2010/12/14 00:50:43, kkania wrote:
> Maybe mention that this navigates the current page?

Done.

http://codereview.chromium.org/5781006/diff/2001/chrome/test/functional/downl...
chrome/test/functional/downloads.py:318: This should exist in the 'dangerous'
directory.
On 2010/12/14 00:50:43, kkania wrote:
> how about change this to take an absolute path (which GetDangerousDownload
> returns), or change GetDangerousDownload to get the relative path? That way
you
> don't have to do os.path.basename.

I want to ensure that the dangerous file exists in the same dir where the .html
lives. Or else I'd need to use relative paths wrt dangerous dir which'll get
more involved. I don't want to give the feeling that it's ok to pass any abs
path to this function.

http://codereview.chromium.org/5781006/diff/2001/chrome/test/functional/downl...
chrome/test/functional/downloads.py:328: self.NavigateToURL(file_url, windex,
tab_index)
On 2010/12/14 00:50:43, kkania wrote:
> Instead of creating the new html page just for redirect, how about just
execute
> the javascript window.location = ... in the current page?

There's no current page yet.

[kkania, 2010-12-14 01:14:48]

http://codereview.chromium.org/5781006/diff/7001/chrome/test/functional/downl...
File chrome/test/functional/downloads.py (right):

http://codereview.chromium.org/5781006/diff/7001/chrome/test/functional/downl...
chrome/test/functional/downloads.py:314: Navigates to download-dangerous.html
which triggers the download.
How about navigating to an already existing file:// page, and then doing
"window.location=..."?

[Nirnimesh, 2010-12-14 01:17:20]

http://codereview.chromium.org/5781006/diff/7001/chrome/test/functional/downl...
File chrome/test/functional/downloads.py (right):

http://codereview.chromium.org/5781006/diff/7001/chrome/test/functional/downl...
chrome/test/functional/downloads.py:314: Navigates to download-dangerous.html
which triggers the download.
On 2010/12/14 01:14:48, kkania wrote:
> How about navigating to an already existing file:// page, and then doing
> "window.location=..."?

I think the current approach better mirrors the usecase experience by the user
wrt dangerous downloads. I could do what you suggested but it feels like bending
over back.

[kkania, 2010-12-14 01:51:26]

LGTM