Issue 5781004: Align builtins-{arch}.cc on ia32 and x64 platforms by moving functions and ed...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5781004: Align builtins-{arch}.cc on ia32 and x64 platforms by moving functions and ed... (Closed)

Created:
10 years ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Align builtins-{arch}.cc on ia32 and x64 platforms by moving functions and editing. Committed: http://code.google.com/p/v8/source/detail?r=5984

Patch Set 1 #

Total comments: 3

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+596 lines, -567 lines)			Patch
M	src/ia32/builtins-ia32.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/builtins-x64.cc	View	6 chunks	+564 lines, -566 lines	3 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Simple change, just reordering the functions within builtins-x64.cc, plus a tiny refactoring noted below. http://codereview.chromium.org/5781004/diff/1/src/x64/builtins-x64.cc ...

10 years ago (2010-12-13 11:25:03 UTC) #1

Lasse Reichstein

10 years ago (2010-12-13 12:03:25 UTC) #2

LGTM, assuming it's only reorderings where you say it is :)

Expand Messages | Collapse Messages