Issue 578025: Refactor code from test/ to utils/ since they are not just used by tests.

Issue 578025: Refactor code from test/ to utils/ since they are not just used by tests. (Closed)

Created:
10 years, 10 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

Refactor code from test/ to utils/ since they are not just used by tests. Also, adds a simple analog of verify_data. BUG=none TEST=none

Patch Set 2 : Added test with modified path. #

Total comments: 4

Patch Set 3 : Fix nits. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -11 lines)			Patch
A +	src/platform/vboot_reference/include/signature_digest.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/platform/vboot_reference/include/verify_data.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/platform/vboot_reference/tests/Makefile	View	1 2	1 chunk	+3 lines, -8 lines	0 comments	Download
M	src/platform/vboot_reference/tests/run_tests.sh	View	2	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/platform/vboot_reference/utils/Makefile	View		1 chunk	+10 lines, -2 lines	0 comments	Download
A	src/platform/vboot_reference/utils/sign_data.sh	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A +	src/platform/vboot_reference/utils/signature_digest.c	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/platform/vboot_reference/utils/verify_data.c	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sosa

lgtm w/ some nits http://codereview.chromium.org/578025/diff/9/12 File src/platform/vboot_reference/tests/Makefile (right): http://codereview.chromium.org/578025/diff/9/12#newcode9 src/platform/vboot_reference/tests/Makefile:9: tests: sha_tests is this a ...

10 years, 10 months ago (2010-02-06 02:42:25 UTC) #3

gauravsh

10 years, 10 months ago (2010-02-06 22:29:52 UTC) #4

http://codereview.chromium.org/578025/diff/9/12
File src/platform/vboot_reference/tests/Makefile (right):

http://codereview.chromium.org/578025/diff/9/12#newcode9
src/platform/vboot_reference/tests/Makefile:9: tests:	sha_tests
On 2010/02/06 02:42:25, sosa wrote:
> is this a dirty tab i see?

Yes, Fixed.

http://codereview.chromium.org/578025/diff/9/13
File src/platform/vboot_reference/tests/run_tests.sh (right):

http://codereview.chromium.org/578025/diff/9/13#newcode14
src/platform/vboot_reference/tests/run_tests.sh:14: UTILDIR=../utils/
On 2010/02/06 02:42:25, sosa wrote:
> you should refactor to UTIL_DIR

Done.

Expand Messages | Collapse Messages