Hopefully final attempt at landing http://src.chromium.org/viewvc/chrome?view...

Hopefully final attempt at landing http://src.chromium.org/viewvc/chrome?view=rev&revision=38207
Adds tests for network geolocation provider.

In the end, it seems templated static methods cannot be called from gtest's SetUp method on a Mac Release build. Beats me. I'm doing my stuff in the c'tor for now, and made a note to come back to it.

BUG=http://crbug.com/11246 
TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure 



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38354

[joth, 2010-02-05 19:32:10]

hopefully for the last time.......

[bulach, 2010-02-08 12:07:58]

few minor comments below:

http://codereview.chromium.org/578017/diff/1/2
File chrome/browser/geolocation/network_location_provider_unittest.cc (right):

http://codereview.chromium.org/578017/diff/1/2#newcode26
chrome/browser/geolocation/network_location_provider_unittest.cc:26: explicit
MessageLoopQuitListener()
s/explicit//

http://codereview.chromium.org/578017/diff/1/2#newcode30
chrome/browser/geolocation/network_location_provider_unittest.cc:30:
DCHECK(client_message_loop_ != NULL);
can just DCHECK

http://codereview.chromium.org/578017/diff/1/2#newcode116
chrome/browser/geolocation/network_location_provider_unittest.cc:116: //
private:
remove?

http://codereview.chromium.org/578017/diff/1/2#newcode381
chrome/browser/geolocation/network_location_provider_unittest.cc:381: // wifi
scan returns to original set: should be serviced from cache
nit: 350 uses "W"ifi instead of "w"ifi.