chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js - Issue 5780002: DOMUI: Fix Shift+Ctrl selection of the list for Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js

Issue 5780002: DOMUI: Fix Shift+Ctrl selection of the list for Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js

diff --git a/chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js b/chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js

index 3697c9d6314c988c393324a7d23102d7110bf8e5..72aada65ec6fbcc4f069984e670cf30fc2f2d381 100644

--- a/chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js

+++ b/chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js

@@ -137,7 +137,8 @@ cr.define('cr.ui', function() {

if (sm.multiple)

sm.unselectAll();

} else {

- if (sm.multiple && (cr.isMac ? e.metaKey : e.ctrlKey)) {

+ if (sm.multiple && (cr.isMac ? e.metaKey :

+ (e.ctrlKey && !e.shiftKey))) {

// Selection is handled at mouseUp on windows/linux, mouseDown on mac.

if (cr.isMac? isDown : !isDown) {

// toggle the current one and make it anchor index

« no previous file with comments | « no previous file | no next file » | no next file with comments »