Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 5778002: Pin the Module after we register a hook.... (Closed)

Created:
10 years ago by MAD
Modified:
9 years, 7 months ago
Reviewers:
Jói
CC:
chromium-reviews, ceee-reviews_chromium.org
Visibility:
Public.

Description

Pin the Module after we register a hook. This shouldn't be needed since the hook machinery is responsible to load our DLL when it's needed, and we only need to register hooks for threads running in the IE process, but we received a dump for a user where the Broker crashed because of a call from the hook machinery to an unmapped address, and this address is within a range where we have seen the ceee_ie dll sit in other debugging session, and in the crash dump, the ceee_ie dll isn't part of the module list. BUG=66434 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ceee/ie/plugin/bho/executor.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
MAD
10 years ago (2010-12-10 19:16:34 UTC) #1
Jói
10 years ago (2010-12-10 19:42:17 UTC) #2
LGTM

Please reassign the bug to me as WillMerge once the change has landed, I will
see if there is any chance of merging this to M9 soon, seeing as it's a trivial
fix to a crash seen in the wild.

Powered by Google App Engine
This is Rietveld 408576698