Suppress remoting_ Valgrind leaks; s/21ResourceMessageFilter/19RenderMessageF...

Suppress remoting_ Valgrind leaks; s/21ResourceMessageFilter/19RenderMessageFilter to fix the massive memory waterfall redness after r69076
TBR=glider
TEST=./tools/valgrind/waterfall.sh
BUG=66808
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69110

[Alexander Potapenko, 2010-12-14 11:12:40]

LGTM

On Tue, Dec 14, 2010 at 12:29 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Suppress remoting_ Valgrind leaks;
> s/21ResourceMessageFilter/19RenderMessageFilter to fix the massive memory
> waterfall redness after r69076
> TBR=glider
> TEST=./tools/valgrind/waterfall.sh
> BUG=66808
>
> Please review this at http://codereview.chromium.org/5777003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> ===================================================================
> --- tools/valgrind/memcheck/suppressions.txt    (revision 69108)
> +++ tools/valgrind/memcheck/suppressions.txt    (working copy)
> @@ -801,7 +801,7 @@
>    ...
>    fun:_ZN30ChromeURLRequestContextFactoryC2EP7Profile
>    ...
> -
>
fun:_ZN21ResourceMessageFilterC1EP22ResourceDispatcherHostiP13PluginServicePN8printing15PrintJobManagerEP7ProfileP18RenderWidgetHelper
> +
>
fun:_ZN19RenderMessageFilterC1EP22ResourceDispatcherHostiP13PluginServicePN8printing15PrintJobManagerEP7ProfileP18RenderWidgetHelper
>    fun:_ZN24BrowserRenderProcessHost20CreateMessageFiltersEv
>    fun:_ZN24BrowserRenderProcessHost4InitEbb
>
>
 fun:_ZN14RenderViewHost16CreateRenderViewERKSbItN4base20string16_char_traitsESaItEE
> @@ -1376,8 +1376,8 @@
>    fun:_Znw*
>    ...
>    fun:_ZN13WorkerService12CreateWorker*
> -   fun:_ZN21ResourceMessageFilter14OnCreateWorker*
> -   fun:_Z16DispatchToMethodI21ResourceMessageFilter*
> +   fun:_ZN19RenderMessageFilter14OnCreateWorker*
> +   fun:_Z16DispatchToMethodI19RenderMessageFilter*
>  }
>  # The following three suppressions are related to the workers code.
>  {
> @@ -2318,10 +2318,10 @@
>    fun:_Znw*
>    fun:_ZNSs4_Rep9_S_createEjjRKSaIcE
>    ...
> -   fun:_ZN31AutomationResourceMessageFilter17OnSetFilteredInetEb
> -
>
fun:_Z16DispatchToMethodI31AutomationResourceMessageFilterMS0_FvbEbEvPT_T0_RK6Tuple1IT1_E
> -
>
fun:_ZN3IPC16MessageWithTupleI6Tuple1IbEE8DispatchI31AutomationResourceMessageFilterMS5_FvbEEEbPKNS_7MessageEPT_T0_
> -
> fun:_ZN31AutomationResourceMessageFilter17OnMessageReceivedERKN3IPC7MessageE
> +   fun:_ZN31AutomationRenderMessageFilter17OnSetFilteredInetEb
> +
>
fun:_Z16DispatchToMethodI31AutomationRenderMessageFilterMS0_FvbEbEvPT_T0_RK6Tuple1IT1_E
> +
>
fun:_ZN3IPC16MessageWithTupleI6Tuple1IbEE8DispatchI31AutomationRenderMessageFilterMS5_FvbEEEbPKNS_7MessageEPT_T0_
> +
> fun:_ZN31AutomationRenderMessageFilter17OnMessageReceivedERKN3IPC7MessageE
>    fun:_ZN3IPC12ChannelProxy7Context10TryFiltersERKNS_7MessageE
>    fun:_ZN3IPC11SyncChannel11SyncContext17OnMessageReceivedERKNS_7MessageE
>    fun:_ZN3IPC7Channel11ChannelImpl23ProcessIncomingMessagesEv
> @@ -2551,8 +2551,8 @@
>    Memcheck:Leak
>    fun:_Znw*
>    fun:_ZN3IPC11SyncMessage13GenerateReplyEPKNS_7MessageE
> -
>
fun:_ZN3IPC16MessageWithReplyI6Tuple2I4GURLSsES1_IRNS_13ChannelHandleER13WebPluginInfoEE18DispatchDelayReplyI21ResourceMessageFilterMSB_FvRKS2_RKSsPNS_7MessageEEEEbPKSG_PT_T0_
> -   fun:_ZN21ResourceMessageFilter17OnMessageReceivedERKN3IPC7MessageE
> +
>
fun:_ZN3IPC16MessageWithReplyI6Tuple2I4GURLSsES1_IRNS_13ChannelHandleER13WebPluginInfoEE18DispatchDelayReplyI19RenderMessageFilterMSB_FvRKS2_RKSsPNS_7MessageEEEEbPKSG_PT_T0_
> +   fun:_ZN19RenderMessageFilter17OnMessageReceivedERKN3IPC7MessageE
>    fun:_ZN3IPC12ChannelProxy7Context10TryFiltersERKNS_7MessageE
>    fun:_ZN3IPC11SyncChannel11SyncContext17OnMessageReceivedERKNS_7MessageE
>    fun:_ZN3IPC7Channel11ChannelImpl23ProcessIncomingMessagesEv
> @@ -3444,3 +3444,10 @@
>
>
 fun:_ZN7WebCore13RootInlineBox26alignBoxesInBlockDirectionEiRN3WTF7HashMapIPKNS_13InlineTextBoxESt4pairINS1_6VectorIPKNS_14SimpleFontDataELj0EEENS_13GlyphOverflowEENS1_7PtrHashIS5_EENS1_10HashTraitsIS5_EENSG_ISD_EEEERNS_21VerticalPositionCacheE
>
>
 fun:_ZN7WebCore11RenderBlock37computeBlockDirectionPositionsForLineEPNS_13RootInlineBoxEPNS_7BidiRunERN3WTF7HashMapIPKNS_13InlineTextBoxESt4pairINS5_6VectorIPKNS_14SimpleFontDataELj0EEENS_13GlyphOverflowEENS5_7PtrHashIS9_EENS5_10HashTraitsIS9_EENSK_ISH_EEEERNS_21VerticalPositionCacheE
>  }
> +{
> +   bug_66808
> +   Memcheck:Leak
> +   fun:_Znw*
> +   ...
> +   fun:_ZN8remoting40HeartbeatSenderTest_ProcessResponse_Test8TestBodyEv
> +}
>
>
>