Make HistoryContentsProvider results deletable

chrome/browser/autocomplete/autocomplete_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete.h"
 #include "chrome/browser/autocomplete/autocomplete_edit.h"
 #include "chrome/browser/autocomplete/autocomplete_edit_view.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
@@ skipping 43 matching lines @@
 
   AutocompleteController* GetAutocompleteController() const {
     return GetLocationBar()->location_entry()->model()->popup_model()->
         autocomplete_controller();
   }
 };
 
 IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, Basic) {
   LocationBar* location_bar = GetLocationBar();
 
-  EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+  EXPECT_TRUE(location_bar->GetInputString().empty());
   EXPECT_EQ(UTF8ToWide(chrome::kAboutBlankURL),
             location_bar->location_entry()->GetText());
   // TODO(phajdan.jr): check state of IsSelectAll when it's consistent across
   // platforms.
 
   location_bar->FocusLocation(true);
 
-  EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+  EXPECT_TRUE(location_bar->GetInputString().empty());
   EXPECT_EQ(UTF8ToWide(chrome::kAboutBlankURL),
             location_bar->location_entry()->GetText());
   EXPECT_TRUE(location_bar->location_entry()->IsSelectAll());
 
   location_bar->location_entry()->SetUserText(L"chrome");
 
-  EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+  EXPECT_TRUE(location_bar->GetInputString().empty());
   EXPECT_EQ(L"chrome", location_bar->location_entry()->GetText());
   EXPECT_FALSE(location_bar->location_entry()->IsSelectAll());
 
   location_bar->location_entry()->RevertAll();
 
-  EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+  EXPECT_TRUE(location_bar->GetInputString().empty());
   EXPECT_EQ(UTF8ToWide(chrome::kAboutBlankURL),
             location_bar->location_entry()->GetText());
   EXPECT_FALSE(location_bar->location_entry()->IsSelectAll());
 
   location_bar->location_entry()->SetUserText(L"chrome");
   location_bar->Revert();
 
-  EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+  EXPECT_TRUE(location_bar->GetInputString().empty());
   EXPECT_EQ(UTF8ToWide(chrome::kAboutBlankURL),
             location_bar->location_entry()->GetText());
   EXPECT_FALSE(location_bar->location_entry()->IsSelectAll());
 }
 
 IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, MAYBE_Autocomplete) {
   // The results depend on the history backend being loaded. Make sure it is
   // loaded so that the autocomplete results are consistent.
   ui_test_utils::WaitForHistoryToLoad(browser());
 
   LocationBar* location_bar = GetLocationBar();
   AutocompleteController* autocomplete_controller = GetAutocompleteController();
 
   {
     autocomplete_controller->Start(L"chrome", std::wstring(),
                                    true, false, true, true);
 
     EXPECT_TRUE(autocomplete_controller->done());
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
-    EXPECT_EQ(std::wstring(), location_bar->location_entry()->GetText());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
+    EXPECT_TRUE(location_bar->location_entry()->GetText().empty());
     EXPECT_TRUE(location_bar->location_entry()->IsSelectAll());
     const AutocompleteResult& result = autocomplete_controller->result();
     ASSERT_EQ(1U, result.size()) << AutocompleteResultAsString(result);
     AutocompleteMatch match = result.match_at(0);
     EXPECT_EQ(AutocompleteMatch::SEARCH_WHAT_YOU_TYPED, match.type);
     EXPECT_FALSE(match.deletable);
   }
 
   {
     location_bar->Revert();
 
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
     EXPECT_EQ(UTF8ToWide(chrome::kAboutBlankURL),
               location_bar->location_entry()->GetText());
     EXPECT_FALSE(location_bar->location_entry()->IsSelectAll());
     const AutocompleteResult& result = autocomplete_controller->result();
     EXPECT_TRUE(result.empty()) << AutocompleteResultAsString(result);
   }
 }
 
 IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, TabAwayRevertSelect) {
   // http://code.google.com/p/chromium/issues/detail?id=38385
@@ skipping 13 matching lines @@
   EXPECT_EQ(UTF8ToWide(chrome::kAboutBlankURL),
             location_bar->location_entry()->GetText());
   EXPECT_TRUE(location_bar->location_entry()->IsSelectAll());
 }
 
 IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, FocusSearch) {
   LocationBar* location_bar = GetLocationBar();
 
   // Focus search when omnibox is blank
   {
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
     EXPECT_EQ(UTF8ToWide(chrome::kAboutBlankURL),
               location_bar->location_entry()->GetText());
 
     location_bar->FocusSearch();
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
     EXPECT_EQ(L"?", location_bar->location_entry()->GetText());
 
     size_t selection_start, selection_end;
     location_bar->location_entry()->GetSelectionBounds(&selection_start,
                                                        &selection_end);
     EXPECT_EQ(1U, selection_start);
     EXPECT_EQ(1U, selection_end);
   }
 
   // Focus search when omnibox is _not_ alread in forced query mode.
   {
     location_bar->location_entry()->SetUserText(L"foo");
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
     EXPECT_EQ(L"foo", location_bar->location_entry()->GetText());
 
     location_bar->FocusSearch();
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
     EXPECT_EQ(L"?", location_bar->location_entry()->GetText());
 
     size_t selection_start, selection_end;
     location_bar->location_entry()->GetSelectionBounds(&selection_start,
                                                        &selection_end);
     EXPECT_EQ(1U, selection_start);
     EXPECT_EQ(1U, selection_end);
   }
 
   // Focus search when omnibox _is_ already in forced query mode, but no query
   // has been typed.
   {
     location_bar->location_entry()->SetUserText(L"?");
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
     EXPECT_EQ(L"?", location_bar->location_entry()->GetText());
 
     location_bar->FocusSearch();
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
     EXPECT_EQ(L"?", location_bar->location_entry()->GetText());
 
     size_t selection_start, selection_end;
     location_bar->location_entry()->GetSelectionBounds(&selection_start,
                                                        &selection_end);
     EXPECT_EQ(1U, selection_start);
     EXPECT_EQ(1U, selection_end);
   }
 
   // Focus search when omnibox _is_ already in forced query mode, and some query
   // has been typed.
   {
     location_bar->location_entry()->SetUserText(L"?foo");
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
     EXPECT_EQ(L"?foo", location_bar->location_entry()->GetText());
 
     location_bar->FocusSearch();
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
     EXPECT_EQ(L"?foo", location_bar->location_entry()->GetText());
 
     size_t selection_start, selection_end;
     location_bar->location_entry()->GetSelectionBounds(&selection_start,
                                                        &selection_end);
     EXPECT_EQ(1U, std::min(selection_start, selection_end));
     EXPECT_EQ(4U, std::max(selection_start, selection_end));
   }
 
   // Focus search when omnibox is in forced query mode with leading whitespace.
   {
     location_bar->location_entry()->SetUserText(L"   ?foo");
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
     EXPECT_EQ(L"   ?foo", location_bar->location_entry()->GetText());
 
     location_bar->FocusSearch();
-    EXPECT_EQ(std::wstring(), location_bar->GetInputString());
+    EXPECT_TRUE(location_bar->GetInputString().empty());
     EXPECT_EQ(L"   ?foo", location_bar->location_entry()->GetText());
 
     size_t selection_start, selection_end;
     location_bar->location_entry()->GetSelectionBounds(&selection_start,
                                                        &selection_end);
     EXPECT_EQ(4U, std::min(selection_start, selection_end));
     EXPECT_EQ(7U, std::max(selection_start, selection_end));
   }
 }