Issue 5774003: emacs: conditionalize behavior based on the OS we're parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5774003: emacs: conditionalize behavior based on the OS we're parsing (Closed)

Created:
10 years ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher, Scott Byer

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/tools/emacs

Visibility:
Public.

Description

emacs: conditionalize behavior based on the OS we're parsing We don't want to run the (expensive) Windows path fixup regex on the (verbose) Mac output. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69055

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : url type hint #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -33 lines)			Patch
	M	tools/emacs/trybot.el	View	1 2	3 chunks	+48 lines, -33 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Scott Byer

LGTM if the string-match goodness is added. http://codereview.chromium.org/5774003/diff/2001/tools/emacs/trybot.el File tools/emacs/trybot.el (right): http://codereview.chromium.org/5774003/diff/2001/tools/emacs/trybot.el#newcode132 tools/emacs/trybot.el:132: ; TODO: ...

10 years ago (2010-12-13 20:03:42 UTC) #2

Scott Byer

10 years ago (2010-12-13 21:27:37 UTC) #4

LGTM

On 2010/12/13 20:30:14, Evan Martin wrote:
> I did a slight variation on your suggestion, PTAL

Expand Messages | Collapse Messages