Issue 577032: The translate feature was only translating the main frame of the page....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 577032: The translate feature was only translating the main frame of the page.... (Closed)

Created:
10 years, 10 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, brettw+cc_chromium.org, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The translate feature was only translating the main frame of the page. This CL makes it also translate frames and iframes. BUG=34533 TEST=See bug for repro case. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38475

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -21 lines)			Patch
M	chrome/renderer/navigation_state.h	View	1 2 3	3 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2 3	4 chunks	+12 lines, -4 lines	0 comments	Download
M	chrome/renderer/translate/page_translator.h	View	1 2 3	1 chunk	+20 lines, -8 lines	0 comments	Download
M	chrome/renderer/translate/page_translator.cc	View	1 2 3	5 chunks	+42 lines, -7 lines	0 comments	Download
M	chrome/renderer/translate/page_translator_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

10 years, 10 months ago (2010-02-06 02:45:20 UTC) #2

LGTM

http://codereview.chromium.org/577032/diff/10/14
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/577032/diff/10/14#newcode2397
chrome/renderer/render_view.cc:2397: if (frame == webview()->mainFrame()) {
nit: I usually just write if (!frame->parent()) instead since it is a bit more
compact.

Expand Messages | Collapse Messages