Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 5769003: PrepopulateRespectBlank working, lets check the other test that was disabled... (Closed)

Created:
10 years ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

PrepopulateRespectBlank working, lets check the other test that was disabled at the same time. I am removing traces from two tests since I think the problem with those tests have been fixed. By suppressing the crash server window on the try servers and ensuring Chrome is in the foreground it looks like the test now works. I went back in time through pages of try server logs and it seems to work. I am also enabling my other test that was disabled at the same time, since I think that test will probably work now. I moved the window caption check to that file, so we can see if we still have the same problem when it fails. BUG=62936, 62937 TEST=This CL is all about tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -98 lines) Patch
M chrome/browser/browser_focus_uitest.cc View 5 chunks +52 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 5 chunks +0 lines, -96 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
10 years ago (2010-12-13 15:53:39 UTC) #1
Paweł Hajdan Jr.
10 years ago (2010-12-13 18:43:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698