Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 5767004: Cleanup: Remove unneeded includes of chrome/browser/cert_store.h and chrome/b... (Closed)

Created:
10 years ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, brettw-cc_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

Cleanup: Remove unneeded includes of chrome/browser/cert_store.h and chrome/browser/defaults.h. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/chromeos/tab_closeable_state_watcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_request_details.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_service_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_policy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_harness.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
Small CL for once.
10 years ago (2010-12-14 01:32:29 UTC) #1
Elliot Glaysher
10 years ago (2010-12-14 01:35:11 UTC) #2
LGTM

On Mon, Dec 13, 2010 at 5:32 PM,  <thestig@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Message:
> Small CL for once.
>
> Description:
> Cleanup: Remove unneeded includes of chrome/browser/cert_store.h and
> chrome/browser/defaults.h.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/5767004/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/chromeos/tab_closeable_state_watcher.cc
>  M     chrome/browser/renderer_host/resource_request_details.h
>  M     chrome/browser/sessions/tab_restore_service_browsertest.cc
>  M     chrome/browser/ssl/ssl_policy.cc
>  M     chrome/browser/sync/profile_sync_factory_impl.cc
>  M     chrome/browser/sync/profile_sync_service_harness.cc
>  M     chrome/browser/tab_contents/tab_contents.cc
>  M     chrome/browser/ui/browser.cc
>
>
> Index: chrome/browser/chromeos/tab_closeable_state_watcher.cc
> ===================================================================
> --- chrome/browser/chromeos/tab_closeable_state_watcher.cc      (revision
> 69075)
> +++ chrome/browser/chromeos/tab_closeable_state_watcher.cc      (working
> copy)
> @@ -6,7 +6,6 @@
>
>  #include "base/command_line.h"
>  #include "chrome/browser/browser_shutdown.h"
> -#include "chrome/browser/defaults.h"
>  #include "chrome/browser/profiles/profile.h"
>  #include "chrome/browser/tab_contents/tab_contents.h"
>  #include "chrome/browser/tab_contents/tab_contents_view.h"
> Index: chrome/browser/renderer_host/resource_request_details.h
> ===================================================================
> --- chrome/browser/renderer_host/resource_request_details.h     (revision
> 69075)
> +++ chrome/browser/renderer_host/resource_request_details.h     (working
> copy)
> @@ -12,7 +12,6 @@
>
>  #include <string>
>
> -#include "chrome/browser/cert_store.h"
>  #include "chrome/browser/renderer_host/resource_dispatcher_host.h"
>  #include
> "chrome/browser/renderer_host/resource_dispatcher_host_request_info.h"
>  #include "chrome/browser/worker_host/worker_service.h"
> Index: chrome/browser/sessions/tab_restore_service_browsertest.cc
> ===================================================================
> --- chrome/browser/sessions/tab_restore_service_browsertest.cc  (revision
> 69075)
> +++ chrome/browser/sessions/tab_restore_service_browsertest.cc  (working
> copy)
> @@ -2,7 +2,6 @@
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> -#include "chrome/browser/defaults.h"
>  #include "chrome/browser/renderer_host/test/test_render_view_host.h"
>  #include "chrome/browser/sessions/session_types.h"
>  #include "chrome/browser/sessions/session_service.h"
> Index: chrome/browser/ssl/ssl_policy.cc
> ===================================================================
> --- chrome/browser/ssl/ssl_policy.cc    (revision 69075)
> +++ chrome/browser/ssl/ssl_policy.cc    (working copy)
> @@ -9,7 +9,6 @@
>  #include "base/singleton.h"
>  #include "base/string_piece.h"
>  #include "base/string_util.h"
> -#include "chrome/browser/cert_store.h"
>  #include "chrome/browser/prefs/pref_service.h"
>  #include "chrome/browser/renderer_host/render_process_host.h"
>  #include "chrome/browser/renderer_host/render_view_host.h"
> Index: chrome/browser/sync/profile_sync_factory_impl.cc
> ===================================================================
> --- chrome/browser/sync/profile_sync_factory_impl.cc    (revision 69075)
> +++ chrome/browser/sync/profile_sync_factory_impl.cc    (working copy)
> @@ -3,7 +3,6 @@
>  // found in the LICENSE file.
>
>  #include "base/command_line.h"
> -#include "chrome/browser/defaults.h"
>  #include "chrome/browser/profiles/profile.h"
>  #include "chrome/browser/sync/glue/app_data_type_controller.h"
>  #include "chrome/browser/sync/glue/autofill_change_processor.h"
> Index: chrome/browser/sync/profile_sync_service_harness.cc
> ===================================================================
> --- chrome/browser/sync/profile_sync_service_harness.cc (revision 69075)
> +++ chrome/browser/sync/profile_sync_service_harness.cc (working copy)
> @@ -3,7 +3,6 @@
>  // found in the LICENSE file.
>
>  #include "base/message_loop.h"
> -#include "chrome/browser/defaults.h"
>  #include "chrome/browser/prefs/pref_service.h"
>  #include "chrome/browser/profiles/profile.h"
>  #include "chrome/browser/net/gaia/token_service.h"
> Index: chrome/browser/tab_contents/tab_contents.cc
> ===================================================================
> --- chrome/browser/tab_contents/tab_contents.cc (revision 69075)
> +++ chrome/browser/tab_contents/tab_contents.cc (working copy)
> @@ -27,7 +27,6 @@
>  #include "chrome/browser/bookmarks/bookmark_model.h"
>  #include "chrome/browser/browser_process.h"
>  #include "chrome/browser/browser_shutdown.h"
> -#include "chrome/browser/cert_store.h"
>  #include "chrome/browser/character_encoding.h"
>  #include "chrome/browser/content_settings/content_settings_details.h"
>  #include "chrome/browser/content_settings/host_content_settings_map.h"
> Index: chrome/browser/ui/browser.cc
> ===================================================================
> --- chrome/browser/ui/browser.cc        (revision 69075)
> +++ chrome/browser/ui/browser.cc        (working copy)
> @@ -118,7 +118,6 @@
>  #include "app/win_util.h"
>  #include "chrome/browser/autofill/autofill_ie_toolbar_import_win.h"
>  #include "chrome/browser/browser_child_process_host.h"
> -#include "chrome/browser/cert_store.h"
>  #include "chrome/browser/download/save_package.h"
>  #include "chrome/browser/ssl/ssl_error_info.h"
>  #include "chrome/browser/shell_integration.h"
>
>
>

Powered by Google App Engine
This is Rietveld 408576698