Issue 5767002: Merge math function ids and custom call generator ids.

Issue 5767002: Merge math function ids and custom call generator ids. (Closed)

Created:
10 years ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, antonm

CC:
v8-dev

Visibility:
Public.

Description

Merge math function ids and custom call generator ids. Two old id types are replaced by builtin function ids. We can use these in the code generators to emit custom code for the selected functions.

Patch Set 2 : arm and x64 fixes. #

Total comments: 5

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -157 lines)			Patch
M	src/arm/lithium-arm.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/ast.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/bootstrapper.cc	View		6 chunks	+15 lines, -16 lines	0 comments	Download
M	src/hydrogen.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/math.js	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/objects.h	View		5 chunks	+49 lines, -32 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+6 lines, -14 lines	2 comments	Download
M	src/runtime.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime.cc	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/stub-cache.h	View		3 chunks	+17 lines, -32 lines	3 comments	Download
M	src/stub-cache.cc	View		1 chunk	+19 lines, -13 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

antonm

DBC http://codereview.chromium.org/5767002/diff/3001/src/stub-cache.h File src/stub-cache.h (right): http://codereview.chromium.org/5767002/diff/3001/src/stub-cache.h#newcode687 src/stub-cache.h:687: // Returns undefined if there is no custom ...

10 years ago (2010-12-13 13:44:15 UTC) #2

Erik Corry

LGTM http://codereview.chromium.org/5767002/diff/3001/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/5767002/diff/3001/src/objects-inl.h#newcode3045 src/objects-inl.h:3045: return HasBuiltinFunctionId() && builtin_function_id() >= kMathFloor; Let's have ...

10 years ago (2010-12-13 14:08:17 UTC) #3

Vitaly Repeshko

10 years ago (2010-12-14 18:55:33 UTC) #4

http://codereview.chromium.org/5767002/diff/3001/src/objects-inl.h
File src/objects-inl.h (right):

http://codereview.chromium.org/5767002/diff/3001/src/objects-inl.h#newcode3045
src/objects-inl.h:3045: return HasBuiltinFunctionId() && builtin_function_id()
>= kMathFloor;
On 2010/12/13 14:08:17, Erik Corry wrote:
> Let's have a real name for this, like kFirstMathFunctionId.

Done.

http://codereview.chromium.org/5767002/diff/3001/src/stub-cache.h
File src/stub-cache.h (right):

http://codereview.chromium.org/5767002/diff/3001/src/stub-cache.h#newcode687
src/stub-cache.h:687: // Returns undefined if there is no custom call code for
the given function.
On 2010/12/13 13:44:15, antonm wrote:
> as you're fixing the wording anyway: undefined can be also returned if custom
> call generator cannot generate the fast code for some reason (e.g. receiver is
> not a JSArray for array push and pop generators)

Done.

Expand Messages | Collapse Messages