Issue 5765002: Make 'media player' resources eligible for retrieval from the appcache....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5765002: Make 'media player' resources eligible for retrieval from the appcache.... (Closed)

Created:
10 years ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
annacc

CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, ddorwin+watch_chromium.org, Alpha Left Google, sjl, acolwell GONE FROM CHROMIUM, darin-cc_chromium.org, awong, scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make 'media player' resources eligible for retrieval from the appcache. BUG=??? TEST=manual

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	webkit/glue/media/buffered_data_source.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

michaeln

Hi Anna... apparently i spoke too soon about this integration working properly, maybe i was ...

10 years ago (2010-12-10 23:39:57 UTC) #1

michaeln

also... can MediaResourceLoaderBridgeFactory now be removed from the project?

10 years ago (2010-12-10 23:41:10 UTC) #2

annacc

Yep, I just caught that a few days ago and was waiting for approval: http://codereview.chromium.org/5515008/ ...

10 years ago (2010-12-11 00:30:11 UTC) #3

michaeln

10 years ago (2010-12-13 21:37:58 UTC) #4

closing this review... anna has this taken care of here...
http://codereview.chromium.org/5515008/

Expand Messages | Collapse Messages