Mac: zoom title and favicon during tabpose zoom animation

Mac: zoom title and favicon during tabpose zoom animation

BUG=50307
TEST=Zoom out in slomo. Favicon and tab titles should fly in like the thumbnails. Zoom back in, they should still look correct.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69323

[viettrungluu, 2010-12-15 17:36:57]

http://codereview.chromium.org/5764002/diff/10001/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabpose_window.mm (right):

http://codereview.chromium.org/5764002/diff/10001/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabpose_window.mm:435: CGFloat scale_small_to_big =
NSWidth(thumb_start) / NSWidth(thumb_rect_);
What is this scale and where does it come from?

Also, I have no idea what "small to big" is supposed to mean.

http://codereview.chromium.org/5764002/diff/10001/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabpose_window.mm:437: rect.origin.x -=
NSMinX(thumb_rect_);
Just make a helper function and do:

  x = ScaleRelativeToPoint(x, ox, scale);

(or whatever) rather than repeating the same three lines a bunch of times.

http://codereview.chromium.org/5764002/diff/10001/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabpose_window.mm:1345: // instead. scale affects the
rendered width, so keep the small bounds.
"|scale|". Or should that be |transform.scale|? ("small" is also confusing; how
about "original" or "base"?)

http://codereview.chromium.org/5764002/diff/10001/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabpose_window.mm:1360: }
This is getting ridiculously big. Please break it up and re-organize it.

[Nico, 2010-12-15 18:52:28]

http://codereview.chromium.org/5764002/diff/10001/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabpose_window.mm (right):

http://codereview.chromium.org/5764002/diff/10001/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabpose_window.mm:435: CGFloat scale_small_to_big =
NSWidth(thumb_start) / NSWidth(thumb_rect_);
On 2010/12/15 17:36:57, viettrungluu wrote:
> What is this scale and where does it come from?
> 
> Also, I have no idea what "small to big" is supposed to mean.

:-(

Renamed the variable. It's the ratio between the size of the full tab contents
and a thumbnail.

http://codereview.chromium.org/5764002/diff/10001/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabpose_window.mm:437: rect.origin.x -=
NSMinX(thumb_rect_);
On 2010/12/15 17:36:57, viettrungluu wrote:
> Just make a helper function and do:
> 
>   x = ScaleRelativeToPoint(x, ox, scale);
> 
> (or whatever) rather than repeating the same three lines a bunch of times.

Ah, but this doesn't do (x - origin) * scale + origin – it does (x -
prescaleOrigin) * scale + postscaleOrigin…done something similar.

http://codereview.chromium.org/5764002/diff/10001/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabpose_window.mm:1345: // instead. scale affects the
rendered width, so keep the small bounds.
On 2010/12/15 17:36:57, viettrungluu wrote:
> "|scale|". Or should that be |transform.scale|? ("small" is also confusing;
how
> about "original" or "base"?)

With "small", it's clear that it refers to the zoomed-out view. "original" or
"base" leave me guessing wich coordinate system the author is talking about.

http://codereview.chromium.org/5764002/diff/10001/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabpose_window.mm:1360: }
On 2010/12/15 17:36:57, viettrungluu wrote:
> This is getting ridiculously big. Please break it up and re-organize it.

It's a sweet 77 lines short!

Alright, done.

[viettrungluu, 2010-12-15 21:32:47]

LGETM

[Nico, 2010-12-15 21:51:29]

On Wed, Dec 15, 2010 at 1:32 PM,  <viettrungluu@chromium.org> wrote:
> LGETM

Minimal gratitude!