Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 5763006: Remove unneeded NSS headers. (Closed)

Created:
10 years ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove unneeded NSS headers and the base::EnsureNSSInit() call. R=cmasone BUG=none TEST=no compilation errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69340

Patch Set 1 #

Total comments: 4

Patch Set 2 : Also remove the EnsureNSSInit call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M chrome/browser/chromeos/login/owner_key_utils.cc View 1 3 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wtc
I see no NSS types or functions in this file, so I believe this file ...
10 years ago (2010-12-14 21:32:48 UTC) #1
Chris Masone
LGTM, w/nit http://codereview.chromium.org/5763006/diff/1/chrome/browser/chromeos/login/owner_key_utils.cc File chrome/browser/chromeos/login/owner_key_utils.cc (right): http://codereview.chromium.org/5763006/diff/1/chrome/browser/chromeos/login/owner_key_utils.cc#newcode98 chrome/browser/chromeos/login/owner_key_utils.cc:98: base::EnsureNSSInit(); On 2010/12/14 21:32:49, wtc wrote: > ...
10 years ago (2010-12-14 22:21:52 UTC) #2
wtc
OK, I removed the base::EnsureNSSInit() call. I will check this in if it passes the ...
10 years ago (2010-12-15 18:11:55 UTC) #3
Chris Masone
10 years ago (2010-12-15 21:41:18 UTC) #4
On 2010/12/15 18:11:55, wtc wrote:
> OK, I removed the base::EnsureNSSInit() call.  I will
> check this in if it passes the linux_chromeos trybot.

assuming it does, lgtm

Powered by Google App Engine
This is Rietveld 408576698