Issue 5763003: autotest: Test that logs can be sent when processes crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5763003: autotest: Test that logs can be sent when processes crash (Closed)

Created:
10 years ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git@master

Visibility:
Public.

Description

autotest: Test that logs can be sent when processes crash Change-Id: I6a92c2251bc16f06d4506c1218cf9f63bf608f24 BUG=9176 TEST=UserCrash,CrashSender Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=dee4e29

Patch Set 1 #

Total comments: 2

Patch Set 2 : Respond to review #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -18 lines)			Patch
M	client/bin/site_crash_test.py	View	1	1 chunk	+10 lines, -7 lines	0 comments	Download
M	client/site_tests/logging_CrashSender/logging_CrashSender.py	View	1	4 chunks	+13 lines, -1 line	0 comments	Download
M	client/site_tests/logging_UserCrash/logging_UserCrash.py	View		10 chunks	+51 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years ago (2010-12-13 19:44:09 UTC) #2

LGTM w/ a couple of nits.

http://codereview.chromium.org/5763003/diff/1/client/bin/site_crash_test.py
File client/bin/site_crash_test.py (right):

http://codereview.chromium.org/5763003/diff/1/client/bin/site_crash_test.py#n...
client/bin/site_crash_test.py:122: def write_fake_meta(self, name, exec_name,
payload, log=None, complete=True):
80 chars

http://codereview.chromium.org/5763003/diff/1/client/site_tests/logging_Crash...
File client/site_tests/logging_CrashSender/logging_CrashSender.py (right):

http://codereview.chromium.org/5763003/diff/1/client/site_tests/logging_Crash...
client/site_tests/logging_CrashSender/logging_CrashSender.py:62: meta_path =
self.write_fake_meta('fake.meta', 'fake', dmp_path, log=log_path)
80 chars

Expand Messages | Collapse Messages