Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 5760004: Added option to set ChromeOS version name, track and AU/dev server URLs via environment variables (Closed)

Created:
10 years ago by Liam McLoughlin
Modified:
9 years ago
Reviewers:
djmm, David McMahon
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, Raja Aluri
Visibility:
Public.

Description

Added option to set ChromeOS version name, track and AU/dev server URLs via environment variables Change-Id: I80914aa49e74edf71914aa93f310104210581ffd BUG=none TEST=Ran a x86-generic build and tested from USB drive Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4a0a239 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=72d0b08

Patch Set 1 #

Patch Set 2 : Added env variable overrides into CHROOT_PASSTHRU #

Patch Set 3 : Removed echo in CHROOT_PASSTHRU change that shouldn't have been there #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M chromeos_version.sh View 2 chunks +8 lines, -8 lines 0 comments Download
M enter_chroot.sh View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Liam McLoughlin
10 years ago (2010-12-14 01:13:27 UTC) #1
davidjames
Adding djmm as reviewer per discussion with cmasone on IRC. Change looks good to me ...
10 years ago (2010-12-14 01:25:23 UTC) #2
David McMahon
That's a fine way to pass in values to make the versions dynamic at build ...
10 years ago (2010-12-14 01:45:42 UTC) #3
Liam McLoughlin
Added another change so that these can be set outside of the chroot, realised this ...
10 years ago (2010-12-14 03:59:48 UTC) #4
David McMahon
LGTM
10 years ago (2010-12-14 18:53:23 UTC) #5
anush
I think you may have to push it for him after the LGTM, if he ...
10 years ago (2010-12-14 19:12:56 UTC) #6
Liam McLoughlin
If you could push this then, that'd be great! :)
10 years ago (2010-12-14 20:38:03 UTC) #7
David McMahon
How does one push for someone else? Is that documented somewhere? Also, the file location ...
10 years ago (2010-12-15 20:49:39 UTC) #8
sosa
repo start <Some branch name> . # Creates branch git cl patch <issue number> # ...
10 years ago (2010-12-15 20:56:39 UTC) #9
anush
Here is the old doc http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/gclient-and-git-faq#TOC-How-do-I-commit-an-issue-for-a-non- I think it needs to be updated and included ...
10 years ago (2010-12-15 20:57:04 UTC) #10
David McMahon
10 years ago (2010-12-15 21:25:51 UTC) #11
Thanks Chris, Anush.
The change(s) are committed.

On Wed, Dec 15, 2010 at 12:56 PM, Chris Sosa <sosa@chromium.org> wrote:

> repo start <Some branch name> . # Creates branch
> git cl patch <issue number> # apply CL
> git cl push -c "First Last <email addy>" # Push change ... but
> attribute contributer.
>
> ... this is probably documented somewhere in the chromium docs but unsure
> where.
>
> On Wed, Dec 15, 2010 at 12:49 PM, David McMahon <djmm@google.com> wrote:
> >
> > How does one push for someone else?  Is that documented somewhere?  Also,
> > the file location has changed.
> >
> > On Tue, Dec 14, 2010 at 12:38 PM, <hexxeh@hexxeh.net> wrote:
> >>
> >> If you could push this then, that'd be great! :)
> >>
> >> http://codereview.chromium.org/5760004/
> >
> >
>

Powered by Google App Engine
This is Rietveld 408576698