Make HelpApp component extension.

chrome/browser/ui/views/browser_actions_container.cc

Index: chrome/browser/ui/views/browser_actions_container.cc
diff --git a/chrome/browser/ui/views/browser_actions_container.cc b/chrome/browser/ui/views/browser_actions_container.cc
index a213e078fec3db1c2c14c6fcdf1e9ace670b1ce2..61024de1345ccce3e24ad6c6f57825146a1bf251 100644
--- a/chrome/browser/ui/views/browser_actions_container.cc
+++ b/chrome/browser/ui/views/browser_actions_container.cc
@@ -251,6 +251,11 @@ void BrowserActionButton::OnMouseExited(const views::MouseEvent& e) {
 
 void BrowserActionButton::ShowContextMenu(const gfx::Point& p,
                                           bool is_mouse_gesture) {
+  // There is nothing in context menu that has sense to show for
+  // component extensions so just ignore the request.
+  if (extension()->location() == Extension::COMPONENT)

[Aaron Boodman, 2011/01/24 19:45:58]

I could see 'options' making sense, but I think this is a good change for now.

What about page actions? They will have the same problem.

How about adding a method to Extension like ::ShowConfigureContextMenus() and
checking that for both page and browser actions.

You can do this in a separate change if you are worried about not being able to
get it done in time for your branch point.

[Dmitry Polukhin, 2011/01/25 07:23:21]

Yes, options would make sense for some component extensions. But HelpApp has no
options at the moment. Showing whole menu with only 1 active item looks odd. It
needs to be revised somehow for component extensions.
I didn't make it. Also the same changes need to be done for Win,Linux,Mac - now
I did it only for Chrome OS.
I like this idea and will send separate CL with such changes.

+    return;
+
   showing_context_menu_ = true;
   SetButtonPushed();