Make HelpApp component extension.

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "app/resource_bundle.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 390 matching lines @@
     } else {
       NOTREACHED();
     }
 
     std::string manifest =
         ResourceBundle::GetSharedInstance().GetRawDataResource(
             iter->second).as_string();
     extensions_service_->register_component_extension(
         ExtensionsService::ComponentExtensionInfo(manifest, path));
   }
+
+#if defined(OS_CHROMEOS)
+  std::string manifest =
+      ResourceBundle::GetSharedInstance().GetRawDataResource(
+          IDR_HELP_MANIFEST).as_string();
+  FilePath path("/usr/share/chromeos-assets/helpapp");

[Aaron Boodman, 2010/12/10 18:38:22]

Can you generalize the std::pair<> above into a struct and give it a constructor
that accepts a path argument? That way all the registration stays in one place.

[Dmitry Polukhin, 2010/12/13 16:17:33]

I did it a bit different but kept registration only in one place. We already
have structs for similar propose (ComponentExtensionInfo) so there is no sense
to create one more that will be used only in one function.

+  extensions_service_->register_component_extension(
+      ExtensionsService::ComponentExtensionInfo(manifest, path));
+#endif
 }
 
 void ProfileImpl::InstallDefaultApps() {
 #if !defined(OS_CHROMEOS)
   // On desktop Chrome, we don't have default apps on by, err, default yet.
   if (!CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableDefaultApps)) {
     return;
   }
 #endif
@@ skipping 934 matching lines @@
 }
 
 PrerenderManager* ProfileImpl::GetPrerenderManager() {
   CommandLine* cl = CommandLine::ForCurrentProcess();
   if (!cl->HasSwitch(switches::kEnablePagePrerender))
     return NULL;
   if (!prerender_manager_.get())
     prerender_manager_.reset(new PrerenderManager(this));
   return prerender_manager_.get();
 }