Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 5757004: Fix ChromeFrame perf test builder redness by delay loading nspr4.dll. We need... (Closed)

Created:
10 years ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix ChromeFrame perf test builder redness by delay loading nspr4.dll. We need to investigate where this dependency comes from. TBR=amit TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome_frame/chrome_frame.gyp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years ago (2010-12-14 05:00:28 UTC) #1
amit
10 years ago (2010-12-14 09:59:18 UTC) #2
lgtm

On Mon, Dec 13, 2010 at 9:00 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix ChromeFrame perf test builder redness by delay loading nspr4.dll. We
> need to
> investigate
> where this dependency comes from.
>
> TBR=amit
> TEST=none
> BUG=none
>
>
> Please review this at http://codereview.chromium.org/5757004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/chrome_frame.gyp
>
>
> Index: chrome_frame/chrome_frame.gyp
> ===================================================================
> --- chrome_frame/chrome_frame.gyp       (revision 69101)
> +++ chrome_frame/chrome_frame.gyp       (working copy)
> @@ -420,7 +420,6 @@
>               'msvs_settings': {
>                 'VCLinkerTool': {
>                   'LinkIncremental':
> '<(msvs_large_module_debug_link_mode)',
> -                  'DelayLoadDLLs': ['nspr4.dll'],
>                 },
>               },
>             },
> @@ -430,6 +429,11 @@
>               '-loleacc.lib',
>             ],
>           },
> +          'msvs_settings': {
> +            'VCLinkerTool': {
> +              'DelayLoadDLLs': ['nspr4.dll'],
> +            },
> +          },
>           'dependencies': [
>             '../breakpad/breakpad.gyp:breakpad_handler',
>             '../chrome/chrome.gyp:automation',
>
>
>

Powered by Google App Engine
This is Rietveld 408576698