Wait for child to exit after killing it.

Wait for child to exit after killing it.

Use general purpose wait in case your connecting to a vm
that you didn't start.

Change-Id: Ie67e2d3235882d372d04e4a44d0781ddfc8d4645

BUG=chromium-os:10121
TEST=Ran it, caused some crashes.  Still ran test after retries.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4a5d7d9

[petkov, 2010-12-09 22:29:02]

LGTM

http://codereview.chromium.org/5757001/diff/1/lib/cros_vm_lib.sh
File lib/cros_vm_lib.sh (right):

http://codereview.chromium.org/5757001/diff/1/lib/cros_vm_lib.sh#newcode25
lib/cros_vm_lib.sh:25: while ps -p ${1} > /dev/null; do
do you want to do a local timeout? e.g., give up after 5 or 10 seconds, rather
than wait indefinitely?

[sosa, 2010-12-09 22:53:26]

PTAL

Added backoff timeout and max timeout wait with a bonus kill -9 in event of
unable to return

[petkov, 2010-12-09 23:01:28]

http://codereview.chromium.org/5757001/diff/7001/lib/cros_vm_lib.sh
File lib/cros_vm_lib.sh (right):

http://codereview.chromium.org/5757001/diff/7001/lib/cros_vm_lib.sh#newcode23
lib/cros_vm_lib.sh:23: # Incrementally backs off timeouts until it is waiting
for 30 seconds and then
by 30 you mean 31 -- 1+2+4+8+16? with the exponential back off you'd wait for 16
seconds, then back off to 32 which will be over the threshold.

http://codereview.chromium.org/5757001/diff/7001/lib/cros_vm_lib.sh#newcode34
lib/cros_vm_lib.sh:34: sudo kill -9 ${1}
the bonus kill here seems to contradict with the function name. if you do a kill
here then maybe roll the SIGTERM kill into this routine and rename it -- e.g.,
kill_and_wait.

And then, if you try kill -9, you should try to wait again, maybe at least a
second or so.

[sosa, 2010-12-09 23:18:15]

PTAL

[petkov, 2010-12-09 23:37:17]

LGTM w/ one concern

http://codereview.chromium.org/5757001/diff/12001/lib/cros_vm_lib.sh
File lib/cros_vm_lib.sh (right):

http://codereview.chromium.org/5757001/diff/12001/lib/cros_vm_lib.sh#newcode38
lib/cros_vm_lib.sh:38: ! ps -p ${1} > /dev/null
don't know bash enough -- are you sure ! switched exit code 0 to non-zero and
vice-versa?