base/test/test_switches.h - Issue 5756004: Separate BufferedDataSource and BufferedResourceLoader into two files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/test/test_switches.h

Issue 5756004: Separate BufferedDataSource and BufferedResourceLoader into two files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments + removed media_resource_loader_bridge_factory + added new timeout to test_timeouts Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | base/test/test_switches.cc » ('j') | base/test/test_switches.cc » ('J')

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_TEST_TEST_SWITCHES_H_	5 #ifndef BASE_TEST_TEST_SWITCHES_H_

6 #define BASE_TEST_TEST_SWITCHES_H_	6 #define BASE_TEST_TEST_SWITCHES_H_

7	7

8 namespace switches {	8 namespace switches {

9	9

10 // All switches in alphabetical order. The switches should be documented	10 // All switches in alphabetical order. The switches should be documented

11 // alongside the definition of their values in the .cc file.	11 // alongside the definition of their values in the .cc file.

12 extern const char kLiveOperationTimeout[];	12 extern const char kLiveOperationTimeout[];

13 extern const char kTestLargeTimeout[];	13 extern const char kTestLargeTimeout[];

14 extern const char kUiTestActionTimeout[];	14 extern const char kUiTestActionTimeout[];

15 extern const char kUiTestActionMaxTimeout[];	15 extern const char kUiTestActionMaxTimeout[];

16 extern const char kUiTestCommandExecutionTimeout[];	16 extern const char kUiTestCommandExecutionTimeout[];

	17 extern const char kUiTestShortTimeout[];
	Paweł Hajdan Jr. 2010/12/13 18:54:32 nit: The "UiTest" part of the switch name is legac nit: The "UiTest" part of the switch name is legacy. Could you rename it to kTestTinyTimeout, and put it right above kTestLargeTimeout? annacc 2010/12/13 20:14:21 Done. Except, I think you meant below (for alphabe Show quoted text On 2010/12/13 18:54:32, Paweł Hajdan Jr. wrote: > nit: The "UiTest" part of the switch name is legacy. Could you rename it to > kTestTinyTimeout, and put it right above kTestLargeTimeout? Done. Except, I think you meant below (for alphabetical order), yes?
17 extern const char kUiTestTerminateTimeout[];	18 extern const char kUiTestTerminateTimeout[];

18 extern const char kUiTestTimeout[];	19 extern const char kUiTestTimeout[];

19	20

20 } // namespace switches	21 } // namespace switches

21	22

22 #endif // BASE_TEST_TEST_SWITCHES_H_	23 #endif // BASE_TEST_TEST_SWITCHES_H_

OLD	NEW