render_view_browsertest.cc: Cast wchar_t to int for snprintf.

render_view_browsertest.cc: Cast wchar_t to int for snprintf.

To print the character code, we should cast the wchar_t to an int.
The code currently happens to work because we don't compile with -fshort-wchars,
and thus wchar_t is four bytes, which coincides with what %d in the
snprintf format string expects. However, it's not portable, and Clang
complains about this.

BUG=none
TEST=browser_tests --gtest_filter=RenderViewTest.OnHandleKeyboardEvent

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69145

[Nico, 2010-12-14 16:08:37]

LG

On Tue, Dec 14, 2010 at 5:49 AM,  <hans@chromium.org> wrote:
> Reviewers: hbono, Nico,
>
> Description:
> render_view_browsertest.cc: Cast wchar_t to int for snprintf.
>
> To print the character code, we should cast the wchar_t to an int.
> The code currently happens to work because we don't compile with
> -fshort-wchars,
> and thus wchar_t is four bytes, which coincides with what %d in the
> snprintf format string expects. However, it's not portable, and Clang
> complains about this.
>
> BUG=none
> TEST=browser_tests --gtest_filter=RenderViewTest.OnHandleKeyboardEvent
>
> Please review this at http://codereview.chromium.org/5755005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/renderer/render_view_browsertest.cc
>
>
> Index: chrome/renderer/render_view_browsertest.cc
> diff --git a/chrome/renderer/render_view_browsertest.cc
> b/chrome/renderer/render_view_browsertest.cc
> index
>
897a9c09bc0bf9ab63a2d37def278cca0c7a3b9b..6a596b57408989d3920cdd64516954e8ff54ecf7
> 100644
> --- a/chrome/renderer/render_view_browsertest.cc
> +++ b/chrome/renderer/render_view_browsertest.cc
> @@ -678,7 +678,8 @@ TEST_F(RenderViewTest, OnHandleKeyboardEvent) {
>                        "%d,%s\n"  // texts in the second <div> element
>                        "%d,%s",   // texts in the third <div> element
>                        key_code, kModifierData[j].expected_result,
> -                       char_code[0], kModifierData[j].expected_result,
> +                       static_cast<int>(char_code[0]),
> +                       kModifierData[j].expected_result,
>                        key_code, kModifierData[j].expected_result);
>
>         // Retrieve the text in the test page and compare it with the
> expected
>
>
>

[Hironori Bono, 2010-12-15 01:42:37]

LGTM2.
Thank you for your change.

Regards,

Hironori Bono