Moving away from shell api to support long path names on windows for filesystem.

base/file_util.h

Index: base/file_util.h
===================================================================
--- base/file_util.h	(revision 69859)
+++ base/file_util.h	(working copy)
@@ -100,6 +100,7 @@
 //
 // WARNING: USING THIS WITH recursive==true IS EQUIVALENT
 //          TO "rm -rf", SO USE WITH CAUTION.
+// Safe to pass extended-path to this method on Windows.

[Erik does not do reviews, 2010/12/23 17:57:27]

It seems better to mark all of the ones that are unsafe and add a TODO / bug #
to all of those so that they can be fixed.

 bool Delete(const FilePath& path, bool recursive);
 
 #if defined(OS_WIN)
@@ -115,6 +116,7 @@
 // If a simple rename is not possible, such as in the case where the paths are
 // on different volumes, this will attempt to copy and delete. Returns
 // true for success.
+// Safe to pass extended paths on Windows.
 bool Move(const FilePath& from_path, const FilePath& to_path);
 
 // Renames file |from_path| to |to_path|. Both paths must be on the same
@@ -125,6 +127,7 @@
 bool ReplaceFile(const FilePath& from_path, const FilePath& to_path);
 
 // Copies a single file. Use CopyDirectory to copy directories.
+// Safe to pass extended-path to this method on Windows.
 bool CopyFile(const FilePath& from_path, const FilePath& to_path);
 
 // Copies the given path, and optionally all subdirectories and their contents
@@ -134,17 +137,20 @@
 // Don't use wildcards on the names, it may stop working without notice.
 //
 // If you only need to copy a file use CopyFile, it's faster.
+// Safe to pass extended-path to this method on Windows.
 bool CopyDirectory(const FilePath& from_path, const FilePath& to_path,
                    bool recursive);
 
 // Returns true if the given path exists on the local filesystem,
 // false otherwise.
+// Safe to use extended path on Windows.
 bool PathExists(const FilePath& path);
 
 // Returns true if the given path is writable by the user, false otherwise.
 bool PathIsWritable(const FilePath& path);
 
 // Returns true if the given path exists and is a directory, false otherwise.
+// Safe to use extended path on Windows.
 bool DirectoryExists(const FilePath& path);
 
 #if defined(OS_WIN)
@@ -238,7 +244,8 @@
                             const FilePath& to_path);
 #endif  // defined(OS_WIN)
 
-// Return true if the given directory is empty
+// Return true if the given directory is empty.
+// Safe to pass extended-path to this method on Windows.
 bool IsDirectoryEmpty(const FilePath& dir_path);
 
 // Get the temporary directory provided by the system.
@@ -287,6 +294,7 @@
 // Creates a directory, as well as creating any parent directories, if they
 // don't exist. Returns 'true' on successful creation, or if the directory
 // already exists.  The directory is only readable by the current user.
+// Safe to pass extended path on Windows.
 bool CreateDirectory(const FilePath& full_path);
 
 // Returns the file size. Returns true on success.
@@ -315,6 +323,7 @@
 #endif
 
 // Returns information about the given file path.
+// Safe to use extended path on Windows.
 bool GetFileInfo(const FilePath& file_path, base::PlatformFileInfo* info);
 
 // Sets the time of the last access and the time of the last modification.