Hook up AXVisited attribute.

Hook up AXVisited attribute.
BUG=58804
TEST=manually with VoiceOver.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68806

[Chris Guillory, 2010-12-09 22:04:02]

One question. LGTM

http://codereview.chromium.org/5751002/diff/1/chrome/browser/accessibility/br...
File chrome/browser/accessibility/browser_accessibility_cocoa.mm (right):

http://codereview.chromium.org/5751002/diff/1/chrome/browser/accessibility/br...
chrome/browser/accessibility/browser_accessibility_cocoa.mm:362: @"AXURL",
Does this URL expect the href value for a link?

[David Tseng, 2010-12-09 22:16:17]

On 12/9/10, ctguil@chromium.org <ctguil@chromium.org> wrote:
> One question. LGTM
>
>
>
http://codereview.chromium.org/5751002/diff/1/chrome/browser/accessibility/br...
> File chrome/browser/accessibility/browser_accessibility_cocoa.mm
> (right):
>
>
http://codereview.chromium.org/5751002/diff/1/chrome/browser/accessibility/br...
> chrome/browser/accessibility/browser_accessibility_cocoa.mm:362:
> @"AXURL",
> Does this URL expect the href value for a link?
>
Yes.  Do we have that information available?  I'm currently using the
ATTR_DOC_URL attribute which seems to only work for the document node.
> http://codereview.chromium.org/5751002/
>

[David Tseng, 2010-12-09 22:21:25]

I'll try ATTR_LINK_TARGET

On 12/9/10, David Tseng <dtseng@chromium.org> wrote:
> On 12/9/10, ctguil@chromium.org <ctguil@chromium.org> wrote:
>> One question. LGTM
>>
>>
>>
http://codereview.chromium.org/5751002/diff/1/chrome/browser/accessibility/br...
>> File chrome/browser/accessibility/browser_accessibility_cocoa.mm
>> (right):
>>
>>
http://codereview.chromium.org/5751002/diff/1/chrome/browser/accessibility/br...
>> chrome/browser/accessibility/browser_accessibility_cocoa.mm:362:
>> @"AXURL",
>> Does this URL expect the href value for a link?
>>
> Yes.  Do we have that information available?  I'm currently using the
> ATTR_DOC_URL attribute which seems to only work for the document node.
>> http://codereview.chromium.org/5751002/
>>
>

[Chris Guillory, 2010-12-09 22:31:16]

On 2010/12/09 22:21:25, David Tseng wrote:
> I'll try ATTR_LINK_TARGET
That looks like it should be the right attribute but it looks like it  isn't set
in webaccessibility.cc. Should be a simple fix to get that set correctly.

[David Tseng, 2010-12-09 23:19:10]

Ok great.  I'll make that change on a subsequent cl.

On 12/9/10, ctguil@chromium.org <ctguil@chromium.org> wrote:
> On 2010/12/09 22:21:25, David Tseng wrote:
>> I'll try ATTR_LINK_TARGET
> That looks like it should be the right attribute but it looks like it
> isn't set
> in webaccessibility.cc. Should be a simple fix to get that set correctly.
>
> http://codereview.chromium.org/5751002/
>

[David Tseng, 2010-12-09 23:39:06]

Actually, I suppose there's no harm in including the differentiation
for ATTR_LINK_TARGET now; I've updated the patch.

On 12/9/10, David Tseng <dtseng@chromium.org> wrote:
> Ok great.  I'll make that change on a subsequent cl.
>
> On 12/9/10, ctguil@chromium.org <ctguil@chromium.org> wrote:
>> On 2010/12/09 22:21:25, David Tseng wrote:
>>> I'll try ATTR_LINK_TARGET
>> That looks like it should be the right attribute but it looks like it
>> isn't set
>> in webaccessibility.cc. Should be a simple fix to get that set correctly.
>>
>> http://codereview.chromium.org/5751002/
>>
>