Default apps promo was getting expired early if NTP open.

chrome/browser/resources/ntp/apps.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var MAX_APPS_PER_ROW = [];
 MAX_APPS_PER_ROW[LayoutMode.SMALL] = 4;
 MAX_APPS_PER_ROW[LayoutMode.NORMAL] = 6;
 
 // The URL prefix used in the app link 'ping' attributes.
 var PING_APP_LAUNCH_PREFIX = 'record-app-launch';
 
 // The URL prefix used in the webstore link 'ping' attributes.
 var PING_WEBSTORE_LAUNCH_PREFIX = 'record-webstore-launch';
 
 function getAppsCallback(data) {
   logEvent('received apps');
+
+  // In the case of prefchange-triggered updates, we don't receive this flag.
+  // Just leave it set as it was before in that case.
+  if ('showPromo' in data)
+    apps.showPromo = data.showPromo;
+
   var appsSection = $('apps');
   var appsSectionContent = $('apps-content');
   var appsMiniview = appsSection.getElementsByClassName('miniview')[0];
   var appsPromo = $('apps-promo');
-  var appsPromoPing = PING_WEBSTORE_LAUNCH_PREFIX + '+' + data.showPromo;
+  var appsPromoPing = PING_WEBSTORE_LAUNCH_PREFIX + '+' + apps.showPromo;
   var webStoreEntry;
 
   // Hide menu options that are not supported on the OS or windowing system.
 
   // The "Launch as Window" menu option.
   $('apps-launch-type-window-menu-item').style.display =
       (data.disableAppWindowLaunch ? 'none' : 'inline');
 
   // The "Create App Shortcut" menu option.
   $('apps-create-shortcut-command-menu-item').style.display =
       (data.disableCreateAppShortcut ? 'none' : 'inline');
 
   appsMiniview.textContent = '';
   appsSectionContent.textContent = '';
 
-  apps.showPromo = data.showPromo;
-
   data.apps.sort(function(a,b) {
     return a.app_launch_index - b.app_launch_index;
   });
 
   clearClosedMenu(apps.menu);
   if (data.apps.length == 0 && !data.showLauncher) {
     appsSection.classList.add('disabled');
     layoutSections();
   } else {
     data.apps.forEach(function(app) {
       appsSectionContent.appendChild(apps.createElement(app));
     });
 
     webStoreEntry = apps.createWebStoreElement();
     webStoreEntry.querySelector('a').setAttribute('ping', appsPromoPing);
     appsSectionContent.appendChild(webStoreEntry);
 
     data.apps.slice(0, MAX_MINIVIEW_ITEMS).forEach(function(app) {
       appsMiniview.appendChild(apps.createMiniviewElement(app));
       addClosedMenuEntryWithLink(apps.menu, apps.createClosedMenuElement(app));
     });
 
     if (!(shownSections & MINIMIZED_APPS)) {
       appsSection.classList.remove('disabled');
     }
   }
   addClosedMenuFooter(apps.menu, 'apps', MINIMIZED_APPS, Section.APPS);
 
   apps.loaded = true;
-  if (data.showPromo)
+  if (apps.showPromo)
     document.documentElement.classList.add('apps-promo-visible');
   else
     document.documentElement.classList.remove('apps-promo-visible');
   $('apps-promo-link').setAttribute('ping', appsPromoPing);
   maybeDoneLoading();
 
   if (data.apps.length > 0 && isDoneLoading()) {
-    if (!data.showPromo && data.apps.length >= MAX_APPS_PER_ROW[layoutMode])
+    if (!apps.showPromo && data.apps.length >= MAX_APPS_PER_ROW[layoutMode])
       webStoreEntry.classList.add('loner');
     else
       webStoreEntry.classList.remove('loner');
 
     updateMiniviewClipping(appsMiniview);
     layoutSections();
   }
 }
 
 function appsPrefChangeCallback(data) {
@@ skipping 243 matching lines @@
       var elm = createElement({
         'id': 'web-store-entry',
         'name': localStrings.getString('web_store_title'),
         'launch_url': localStrings.getString('web_store_url')
       });
       elm.setAttribute('app-id', 'web-store-entry');
       return elm;
     }
   };
 })();