Issue 5750003: Reland r68893 after fixing allowing blocking IO on shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5750003: Reland r68893 after fixing allowing blocking IO on shutdown. (Closed)

Created:
10 years ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Reland r68893 after fixing allowing blocking IO on shutdown. This time I just turned off the checking for Chrome/Windows because Chrome/Windows shutdown is a clusterf***. TODO(willchan): Give a shit about Windows, get a machine that runs Windows, debug Chrome shutdown on Windows, enable this ThreadRestrictions for Chrome/Windows. Consider PlatformThread::Join() to be blocking IO. Marks PlatformThread::Join() as blocking IO using ThreadRestrictions. Whitelists existing spots where we join on the UI/IO threads. Also noteworthy is I allow blocking IO on shutdown. BUG=65530, 66077, 66082 TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69079

Patch Set 1 #

Patch Set 2 : Disable for Windows. #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
M	base/platform_thread_posix.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/platform_thread_win.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_provider.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/printing/printer_query.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download