Issue 5750001: Add safe browsing tests to dbg mac valgrind build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5750001: Add safe browsing tests to dbg mac valgrind build. (Closed)

Created:
10 years ago by lzheng

Modified:
9 years, 7 months ago

Reviewers:
lzheng1, Timur Iskhodzhanov

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add safe browsing tests to dbg mac valgrind build. BUG=64089 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68861

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/all.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

Can you please send it the mac_valgrind trybot to make sure it builds? On 2010/12/09 ...

10 years ago (2010-12-09 21:51:26 UTC) #2

Timur Iskhodzhanov

If it compiles fine - LGTM. Please disregard test failures - mac_valgrind trybots are 10.6 ...

10 years ago (2010-12-09 21:52:12 UTC) #3

lzheng1

10 years ago (2010-12-10 00:31:55 UTC) #4

Looks like it was built:
http://build.chromium.org/p/tryserver.chromium/builders/mac_valgrind/builds/1...
...

Ld ../xcodebuild/Debug/safe_browsing_tests normal i386

<http://build.chromium.org/p/tryserver.chromium/builders/mac_valgrind/builds/1...>
Submitting.

On Thu, Dec 9, 2010 at 1:52 PM, <timurrrr@chromium.org> wrote:

> If it compiles fine - LGTM.
> Please disregard test failures - mac_valgrind trybots are 10.6 which is not
> yet
> supported by Valgrind :)
>
>
> On 2010/12/09 21:51:26, Timur Iskhodzhanov wrote:
>
>> Can you please send it the mac_valgrind trybot to make sure it builds?
>>
>
>  On 2010/12/09 21:46:00, lzheng wrote:
>> > This address comments in code review for 5739001
>>
>
>
>
> http://codereview.chromium.org/5750001/
>

Expand Messages | Collapse Messages