Chromium Code Reviews| Index: ipc/ipc_channel_win.cc |
| diff --git a/ipc/ipc_channel_win.cc b/ipc/ipc_channel_win.cc |
| index e12c521d2552073389f0120fd9302fa96b996503..0e7ba1b3b63f83cba31b05d99ac745c087979adf 100644 |
| --- a/ipc/ipc_channel_win.cc |
| +++ b/ipc/ipc_channel_win.cc |
| @@ -106,6 +106,22 @@ Channel::ChannelImpl::ChannelImpl(const IPC::ChannelHandle &channel_handle, |
| waiting_connect_(mode == MODE_SERVER), |
| processing_incoming_(false), |
| ALLOW_THIS_IN_INITIALIZER_LIST(factory_(this)) { |
| + switch(mode) { |
| + case MODE_NONE: |
| + LOG(FATAL) << "Bad mode for " << channel_handle.name; |
| + break; |
| + case MODE_SERVER: |
| + case MODE_CLIENT: |
| + break; |
| + case MODE_NAMED_SERVER: |
| + mode = MODE_SERVER; |
| + break; |
| + case MODE_NAMED_CLIENT: |
| + mode = MODE_CLIENT; |
| + break; |
| + // Intentionally no default case here so that the compiler |
|
Evan Martin
2010/12/14 20:23:19
I think this comment is superfluous, but it's your
dmac
2010/12/14 21:01:16
I'm going to leave it as I have had other devs ask
|
| + // will check that we handle all the cases in the enum. |
| + } |
| if (!CreatePipe(channel_handle, mode)) { |
| // The pipe may have been closed already. |
| LOG(WARNING) << "Unable to create pipe named \"" << channel_handle.name << |