Issue 5748007: Suppress Heapchecker memory leaks in remoting_unittests...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5748007: Suppress Heapchecker memory leaks in remoting_unittests... (Closed)

Created:
10 years ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Suppress Heapchecker memory leaks in remoting_unittests BUG=66808 TBR=glider TEST=heapchecker bot should go greener Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69109

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years ago (2010-12-14 09:53:55 UTC) #2

LGTM

On Tue, Dec 14, 2010 at 12:20 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Suppress Heapchecker memory leaks in remoting_unittests
> BUG=66808
> TBR=glider
> TEST=heapchecker bot should go greener
>
> Please review this at http://codereview.chromium.org/5748007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/heapcheck/suppressions.txt
>
>
> Index: tools/heapcheck/suppressions.txt
> ===================================================================
> --- tools/heapcheck/suppressions.txt    (revision 69108)
> +++ tools/heapcheck/suppressions.txt    (working copy)
> @@ -1124,3 +1124,9 @@
>    ...
>    fun:MalwareDetailsTest_*
>  }
> +{
> +   bug_66808
> +   Heapcheck:Leak
> +   ...
> +   fun:remoting::HeartbeatSenderTest_ProcessResponse_Test::TestBody
> +}
>
>
>

Expand Messages | Collapse Messages