Add the virtual keyboard to BrowserFrameChromeos.

chrome/browser/ui/touch/frame/touch_browser_frame_view.cc

Index: chrome/browser/ui/touch/frame/touch_browser_frame_view.cc
diff --git a/chrome/browser/ui/touch/frame/touch_browser_frame_view.cc b/chrome/browser/ui/touch/frame/touch_browser_frame_view.cc
new file mode 100644
index 0000000000000000000000000000000000000000..eadefa8a1524a5a440359a355dccba81bfa57cf5
--- /dev/null
+++ b/chrome/browser/ui/touch/frame/touch_browser_frame_view.cc
@@ -0,0 +1,107 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/touch/frame/touch_browser_frame_view.h"
+
+#include <algorithm>
+
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/renderer_host/site_instance.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/views/dom_view.h"
+#include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/common/notification_service.h"
+#include "chrome/common/notification_type.h"
+#include "chrome/common/url_constants.h"
+#include "gfx/rect.h"
+
+namespace {
+
+const int kKeyboardHeight = 300;
+
+}  // namespace
+
+///////////////////////////////////////////////////////////////////////////////
+// TouchBrowserFrameView, public:
+
+TouchBrowserFrameView::TouchBrowserFrameView(BrowserFrame* frame,
+                                             BrowserView* browser_view)
+    : OpaqueBrowserFrameView(frame, browser_view),
+      keyboard_(NULL) {
+  registrar_.Add(this,
+                 NotificationType::NAV_ENTRY_COMMITTED,
+                 NotificationService::AllSources());
+  registrar_.Add(this,
+                 NotificationType::FOCUS_CHANGED_IN_PAGE,
+                 NotificationService::AllSources());
+}
+
+TouchBrowserFrameView::~TouchBrowserFrameView() {
+}
+
+///////////////////////////////////////////////////////////////////////////////
+// TouchBrowserFrameView, protected:
+int TouchBrowserFrameView::GetReservedHeight() const {
+  if (keyboard_ && keyboard_->IsVisible()) {
+    return kKeyboardHeight;
+  }
+  return 0;
+}
+
+///////////////////////////////////////////////////////////////////////////////
+// TouchBrowserFrameView, private:
+
+void TouchBrowserFrameView::InitVirtualKeyboard() {
+  if (keyboard_)
+    return;
+
+  keyboard_ = new DOMView;
+
+  Profile* keyboard_profile = browser_view()->browser()->profile();
+  DCHECK(keyboard_profile) << "Profile required for virtual keyboard.";
+
+  GURL keyboard_url(chrome::kChromeUIKeyboardURL);
+  keyboard_->Init(keyboard_profile,
+      SiteInstance::CreateSiteInstanceForURL(keyboard_profile, keyboard_url));
+  keyboard_->LoadURL(keyboard_url);
+
+  keyboard_->SetVisible(false);
+  AddChildView(keyboard_);
+}
+
+void TouchBrowserFrameView::UpdateKeyboardAndLayout(bool should_show_keyboard) {
+  // If we have not created the keyboard yet, then we can safely skip

[sky, 2010/12/10 18:18:20]

Wouldn't it be better to have this method call InitVirtualKeyboard if needed?

[bryeung, 2010/12/10 23:58:59]

If we try to InitVirtualKeyboard too early, it will crash because the extensions
system isn't ready.  I think it is better to ignore all the notifications
throughout startup, until the keyboard has been shown.

[sky, 2010/12/13 17:37:37]

My comment wasn't very good. I'm suggesting you make this invoke
InitVirtualKeyboard if should_show_keyboard is true. That way other places that
might need to show the keyboard only invoke this method and don't have to worry
about also needing to invoke InitVirtualKeyboard (as you do @ line 95).

+  // this method as must be trying to hide it.
+  if (!keyboard_) {
+    DCHECK(!should_show_keyboard);
+    return;
+  }
+
+  if (should_show_keyboard == keyboard_->IsVisible())
+    return;
+
+  keyboard_->SetVisible(should_show_keyboard);
+
+  // Because the NonClientFrameView is a sibling of the ClientView,
+  // we rely on the parent to properly resize the ClientView.
+  GetParent()->Layout();
+}
+
+void TouchBrowserFrameView::Observe(NotificationType type,
+                                    const NotificationSource& source,
+                                    const NotificationDetails& details) {
+  if (type == NotificationType::FOCUS_CHANGED_IN_PAGE) {
+    InitVirtualKeyboard();
+    UpdateKeyboardAndLayout(*Details<const bool>(details).ptr());

[sky, 2010/12/10 18:18:20]

You're going to support multiple windows, right? You should only show the
keyboard if focus changed in this window.

[bryeung, 2010/12/10 23:58:59]

TOUCH_UI will not support multiple windows.

[sky, 2010/12/13 17:37:37]

Remember that panels/popups are also browser windows.
Also, it's a lot easier to add the check now rather than at some future point
when you know folks will change their mind (perhaps incognito) and you'll have
to go back and patch places like this.

+  } else {
+    DCHECK(type == NotificationType::NAV_ENTRY_COMMITTED);
+
+    // TODO(bryeung): this is hiding the keyboard for the very first page
+    //   load after browser startup when the page has an input element focused
+    //   to start with.  It would be nice to fix, but not critical.
+
+    // Everything else we have registered for should hide the keyboard.
+    UpdateKeyboardAndLayout(false);
+  }
+}