Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: chrome_frame/test/test_with_web_server.cc

Issue 5745008: Disable the ChromeFrame Firefox tests on Windows 7 due to a bug in Firefox ca... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/test_with_web_server.cc
===================================================================
--- chrome_frame/test/test_with_web_server.cc (revision 69077)
+++ chrome_frame/test/test_with_web_server.cc (working copy)
@@ -226,6 +226,11 @@
void ChromeFrameTestWithWebServer::SimpleBrowserTest(BrowserKind browser,
const wchar_t* page) {
+ if (browser == FIREFOX &&
+ base::win::GetVersion() == base::win::VERSION_WIN7) {
+ LOG(INFO) << "Not running Firefox tests on Windows 7";
+ return;
+ }
SimpleBrowserTestExpectedResult(browser, page, "OK");
}
@@ -244,6 +249,12 @@
void ChromeFrameTestWithWebServer::VersionTest(BrowserKind browser,
const wchar_t* page) {
+ if (browser == FIREFOX &&
+ base::win::GetVersion() == base::win::VERSION_WIN7) {
+ LOG(INFO) << "Not running Firefox tests on Windows 7";
+ return;
+ }
+
FilePath plugin_path;
PathService::Get(base::DIR_MODULE, &plugin_path);
plugin_path = plugin_path.AppendASCII("servers");
@@ -291,6 +302,12 @@
const wchar_t* page,
int privilege_mode,
const char* expected_result) {
+ if (browser == FIREFOX &&
+ base::win::GetVersion() == base::win::VERSION_WIN7) {
+ LOG(INFO) << "Not running Firefox tests on Windows 7";
+ return;
+ }
+
SetConfigInt(kEnableFirefoxPrivilegeMode, privilege_mode);
EXPECT_TRUE(LaunchBrowser(browser, page));
server_mock_.set_expected_result(expected_result);
@@ -1052,13 +1069,6 @@
}
TEST_F(ChromeFrameTestWithWebServer, FullTabModeFF_WindowClose) {
- // Please see http://code.google.com/p/chromium/issues/detail?id=60987
- // for more information on why this test is disabled for Vista with IE7.
- if (base::win::GetVersion() == base::win::VERSION_VISTA &&
- chrome_frame_test::GetInstalledIEVersion() == IE_7) {
- LOG(INFO) << "Not running test on Vista with IE7";
- return;
- }
SimpleBrowserTest(FIREFOX, kWindowCloseTestUrl);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698