Refactor PipelineImpl to use CompositeFilter to manage Filter state transitions.

media/base/mock_filters.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A new breed of mock media filters, this time using gmock!  Feel free to add
 // actions if you need interesting side-effects (i.e., copying data to the
 // buffer passed into MockDataSource::Read()).
 //
 // Don't forget you can use StrictMock<> and NiceMock<> if you want the mock
 // filters to fail the test or do nothing when an unexpected method is called.
@@ skipping 32 matching lines @@
  private:
   DISALLOW_COPY_AND_ASSIGN(Destroyable);
 };
 
 // Helper class used to test that callbacks are executed.  It is recommend you
 // combine this class with StrictMock<> to verify that the callback is executed.
 // You can reuse the same instance of a MockFilterCallback many times since
 // gmock will track the number of times the methods are executed.
 class MockFilterCallback {
  public:
-  MockFilterCallback() {}
+  MockFilterCallback() : run_destroy_callback_(true) {
+  }
+
+  MockFilterCallback(bool run_destroy_callback) :
+      run_destroy_callback_(run_destroy_callback) {

[scherkus (not reviewing), 2010/12/20 20:36:21]

nit: de-indent two spaces

+  }
   virtual ~MockFilterCallback() {}
 
   MOCK_METHOD0(OnCallbackDestroyed, void());
   MOCK_METHOD0(OnFilterCallback, void());
 
   // Helper method to create a new callback for this mock.  The callback will
   // call OnFilterCallback() when executed and OnCallbackDestroyed() when
   // destroyed.  Clients should use NiceMock<> or StrictMock<> depending on the
   // test.
   FilterCallback* NewCallback() {
-    return new CallbackImpl(this);
+    return new CallbackImpl(this, run_destroy_callback_);
   }
 
  private:
   // Private implementation of CallbackRunner used to trigger expectations on
   // MockFilterCallback.
   class CallbackImpl : public CallbackRunner<Tuple0> {
    public:
-    explicit CallbackImpl(MockFilterCallback* mock_callback)
-        : mock_callback_(mock_callback) {
+    explicit CallbackImpl(MockFilterCallback* mock_callback,
+                          bool run_destroy_callback)
+        : mock_callback_(mock_callback),
+          run_destroy_callback_(run_destroy_callback) {
     }
 
     virtual ~CallbackImpl() {
-      mock_callback_->OnCallbackDestroyed();
+      if (run_destroy_callback_)
+        mock_callback_->OnCallbackDestroyed();
     }
 
     virtual void RunWithParams(const Tuple0& params) {
       mock_callback_->OnFilterCallback();
     }
 
    private:
     MockFilterCallback* mock_callback_;
+    bool run_destroy_callback_;
 
     DISALLOW_COPY_AND_ASSIGN(CallbackImpl);
   };
 
+  bool run_destroy_callback_;
   DISALLOW_COPY_AND_ASSIGN(MockFilterCallback);
 };
 
+class MockFilter : public Filter {
+ public:
+  MockFilter();
+  MockFilter(bool requires_message_loop);
+
+  // Filter implementation.
+  virtual bool requires_message_loop() const;
+  virtual const char* message_loop_name() const;
+
+  MOCK_METHOD1(Play, void(FilterCallback* callback));
+  MOCK_METHOD1(Pause, void(FilterCallback* callback));
+  MOCK_METHOD1(Flush, void(FilterCallback* callback));
+  MOCK_METHOD1(Stop, void(FilterCallback* callback));
+  MOCK_METHOD1(SetPlaybackRate, void(float playback_rate));
+  MOCK_METHOD2(Seek, void(base::TimeDelta time, FilterCallback* callback));
+  MOCK_METHOD0(OnAudioRendererDisabled, void());
+
+ protected:
+  virtual ~MockFilter();
+
+ private:
+  bool requires_message_loop_;
+
+  DISALLOW_COPY_AND_ASSIGN(MockFilter);
+};
+
 class MockDataSource : public DataSource {
  public:
   MockDataSource() {}
 
   // Filter implementation.
   MOCK_METHOD1(Stop, void(FilterCallback* callback));
   MOCK_METHOD1(SetPlaybackRate, void(float playback_rate));
   MOCK_METHOD2(Seek, void(base::TimeDelta time, FilterCallback* callback));
   MOCK_METHOD0(OnAudioRendererDisabled, void());
 
@@ skipping 251 matching lines @@
 
 // Helper gmock action that calls DisableAudioRenderer() on behalf of the
 // provided filter.
 ACTION_P(DisableAudioRenderer, filter) {
   filter->host()->DisableAudioRenderer();
 }
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_MOCK_FILTERS_H_