Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2441)

Unified Diff: chrome/browser/printing/printer_query.cc

Issue 5743005: Revert 68893 - Consider PlatformThread::Join() to be blocking IO.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/geolocation/geolocation_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/printer_query.cc
===================================================================
--- chrome/browser/printing/printer_query.cc (revision 68914)
+++ chrome/browser/printing/printer_query.cc (working copy)
@@ -5,7 +5,6 @@
#include "chrome/browser/printing/printer_query.h"
#include "base/message_loop.h"
-#include "base/thread_restrictions.h"
#include "chrome/browser/printing/print_job_worker.h"
namespace printing {
@@ -97,10 +96,6 @@
void PrinterQuery::StopWorker() {
if (worker_.get()) {
- // http://crbug.com/66082: We're blocking on the PrinterQuery's worker
- // thread. It's not clear to me if this may result in blocking the current
- // thread for an unacceptable time. We should probably fix it.
- base::ThreadRestrictions::ScopedAllowIO allow_io;
worker_->Stop();
worker_.reset();
}
« no previous file with comments | « chrome/browser/geolocation/geolocation_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698