Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: chrome/browser/geolocation/geolocation_provider.cc

Issue 5743005: Revert 68893 - Consider PlatformThread::Join() to be blocking IO.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/printing/printer_query.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/geolocation/geolocation_provider.cc
===================================================================
--- chrome/browser/geolocation/geolocation_provider.cc (revision 68914)
+++ chrome/browser/geolocation/geolocation_provider.cc (working copy)
@@ -5,7 +5,6 @@
#include "chrome/browser/geolocation/geolocation_provider.h"
#include "base/singleton.h"
-#include "base/thread_restrictions.h"
#include "chrome/browser/geolocation/location_arbitrator.h"
// This class is guaranteed to outlive its internal thread, so ref counting
@@ -48,10 +47,6 @@
void GeolocationProvider::OnObserversChanged() {
DCHECK(OnClientThread());
if (observers_.empty()) {
- // http://crbug.com/66077: This is a bug. The geolocation thread may
- // transitively (via other threads it joins) block on long-running tasks /
- // IO.
- base::ThreadRestrictions::ScopedAllowIO allow_io;
Stop();
} else {
if (!IsRunning()) {
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/printing/printer_query.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698