base/platform_thread_win.cc - Issue 5743005: Revert 68893 - Consider PlatformThread::Join() to be blocking IO....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/platform_thread_win.cc

Issue 5743005: Revert 68893 - Consider PlatformThread::Join() to be blocking IO.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/platform_thread_win.cc

===================================================================

--- base/platform_thread_win.cc (revision 68914)

+++ base/platform_thread_win.cc (working copy)

@@ -125,10 +125,6 @@

// static

void PlatformThread::Join(PlatformThreadHandle thread_handle) {

DCHECK(thread_handle);

- // Joining another thread may block the current thread for a long time, since

- // the thread referred to by |thread_handle| may still be running long-lived /

- // blocking tasks.

- base::ThreadRestrictions::AssertIOAllowed();

// Wait for the thread to exit. It should already have terminated but make

// sure this assumption is valid.

« no previous file with comments | « base/platform_thread_posix.cc ('k') | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »