Clean up threading model of external extension providers

chrome/browser/extensions/external_extension_loader.h

Index: chrome/browser/extensions/external_extension_loader.h
diff --git a/chrome/browser/extensions/external_extension_loader.h b/chrome/browser/extensions/external_extension_loader.h
new file mode 100644
index 0000000000000000000000000000000000000000..b32db6e394659443e07a8e61b0cfc6dabae0ac4b
--- /dev/null
+++ b/chrome/browser/extensions/external_extension_loader.h
@@ -0,0 +1,68 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTERNAL_EXTENSION_LOADER_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTERNAL_EXTENSION_LOADER_H_
+#pragma once
+
+#include "base/lock.h"
+#include "base/ref_counted.h"
+#include "base/scoped_ptr.h"
+
+class DictionaryValue;
+class ExternalExtensionProviderImpl;
+
+// Base class for gathering a list of external extensions. Subclasses
+// implement loading from registry, JSON file, policy.
+// Instances are owned by ExternalExtensionProviderImpl objects.
+// Instances are created on the UI thread and expect public method calls from
+// the UI thread. Some subclasses introduce new methods that are executed on the
+// FILE thread.
+// The sequence of loading the extension list:
+// 1.) StartLoading() - checks if a loading task is already running
+// 2.) Load() - implemented in subclasses
+// 3.) FinishLoading()
+// 4.) owner_->SetPrefs()
+class ExternalExtensionLoader
+    : public base::RefCountedThreadSafe<ExternalExtensionLoader> {
+ public:
+  explicit ExternalExtensionLoader() : running_(false) {}
+
+  // Specifies the provider that owns this object.
+  void Init(ExternalExtensionProviderImpl* owner);
+
+  // Called by the owner before it gets deleted.
+  void OwnerShutdown();
+
+  // Initiates the possibly asynchronous loading of extension list.
+  void StartLoading();
+
+ protected:
+  virtual ~ExternalExtensionLoader() {}
+
+  // Notifies the provider that the list of extensions has been loaded.
+  void LoadFinished();
+
+  // The external-source specific logic that loads the list of extensions.
+  virtual void Load() = 0;
+
+  // Protects |prefs_|.
+  Lock lock_;
+
+  // Used for passing the list of extensions from the method that loads them
+  // to |LoadFinished|. Depending on the implementation of |Load|, this
+  // may be accessed from multiple threads.
+  scoped_ptr<DictionaryValue> prefs_;
+
+ private:
+  friend class base::RefCountedThreadSafe<ExternalExtensionLoader>;
+
+  ExternalExtensionProviderImpl* owner_;  // weak
+
+  // Set to true if loading the extensions is already running. New requests
+  // are ignored while this is set true.
+  bool running_;
+};

[jochen (gone - plz use gerrit), 2011/01/04 12:38:01]

disallow copy and assign?

[gfeher, 2011/01/04 23:37:09]

Done.

+
+#endif  // CHROME_BROWSER_EXTENSIONS_EXTERNAL_EXTENSION_LOADER_H_