chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h - Issue 5741001: Even more virtual method deinlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h

Issue 5741001: Even more virtual method deinlining. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase (windows) Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h

diff --git a/chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h b/chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h

index eb647904317ca579a148ec9f22811c6f5528489d..ddc180855f8b32d291b20b108e0ad742d8b20a7d 100644

--- a/chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h

+++ b/chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h

@@ -56,7 +56,7 @@ class AppModalDialog {

// added to the AppModalDialogQueue. When the current modal dialog finishes

// and it's time to show the next dialog in the queue IsValid is invoked.

// If IsValid returns false the dialog is deleted and not shown.

- virtual bool IsValid() { return !skip_this_dialog_; }

+ virtual bool IsValid();

protected:

// Overridden by subclasses to create the feature-specific native dialog box.