chrome/browser/sync/engine/model_changing_syncer_command.h - Issue 5741001: Even more virtual method deinlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/model_changing_syncer_command.h

Issue 5741001: Even more virtual method deinlining. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase (windows) Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/engine/model_changing_syncer_command.h

diff --git a/chrome/browser/sync/engine/model_changing_syncer_command.h b/chrome/browser/sync/engine/model_changing_syncer_command.h

index ae59272f46040856a8487abcd1d33ccfcae6eaf7..f6d6a436ac7e22966609258a08681b3f0a7df171 100644

--- a/chrome/browser/sync/engine/model_changing_syncer_command.h

+++ b/chrome/browser/sync/engine/model_changing_syncer_command.h

@@ -42,9 +42,7 @@ class ModelChangingSyncerCommand : public SyncerCommand {

// *without* a ModelSafeGroup restriction in place on the SyncSession.

// Returns true on success, false on failure.

// TODO(tim): Remove this (bug 36594).

- virtual bool ModelNeutralExecuteImpl(sessions::SyncSession* session) {

- return true;

- }

+ virtual bool ModelNeutralExecuteImpl(sessions::SyncSession* session);

// Abstract method to be implemented by subclasses to handle logic that

// operates on the model. This is invoked with a SyncSession ModelSafeGroup