Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: app/tree_model.h

Issue 5741001: Even more virtual method deinlining. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase (windows) Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/multi_animation.cc ('k') | app/tree_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/tree_model.h
diff --git a/app/tree_model.h b/app/tree_model.h
index df06b9f8109b09a54c3fa0f3aae4394f2d25c903..a4ac06f31244fe9881e714ed82921429b79cdeca 100644
--- a/app/tree_model.h
+++ b/app/tree_model.h
@@ -8,7 +8,6 @@
#include <vector>
-#include "base/logging.h"
#include "base/string16.h"
class SkBitmap;
@@ -78,10 +77,7 @@ class TreeModel {
// Sets the title of the specified node.
// This is only invoked if the node is editable and the user edits a node.
- virtual void SetTitle(TreeModelNode* node,
- const string16& title) {
- NOTREACHED();
- }
+ virtual void SetTitle(TreeModelNode* node, const string16& title);
// Returns the set of icons for the nodes in the tree. You only need override
// this if you don't want to use the default folder icons.
@@ -90,7 +86,7 @@ class TreeModel {
// Returns the index of the icon to use for |node|. Return -1 to use the
// default icon. The index is relative to the list of icons returned from
// GetIcons.
- virtual int GetIconIndex(TreeModelNode* node) { return -1; }
+ virtual int GetIconIndex(TreeModelNode* node);
protected:
virtual ~TreeModel() {}
« no previous file with comments | « app/multi_animation.cc ('k') | app/tree_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698