Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: webkit/glue/webmediaplayer_impl.h

Issue 5741001: Even more virtual method deinlining. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase (windows) Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/plugins/plugin_stream.cc ('k') | webkit/glue/webmediaplayer_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player. 5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player.
6 // It contains PipelineImpl which is the actual media player pipeline, it glues 6 // It contains PipelineImpl which is the actual media player pipeline, it glues
7 // the media player pipeline, data source, audio renderer and renderer. 7 // the media player pipeline, data source, audio renderer and renderer.
8 // PipelineImpl would creates multiple threads and access some public methods 8 // PipelineImpl would creates multiple threads and access some public methods
9 // of this class, so we need to be extra careful about concurrent access of 9 // of this class, so we need to be extra careful about concurrent access of
10 // methods and members. 10 // methods and members.
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 virtual bool seeking() const; 219 virtual bool seeking() const;
220 virtual float duration() const; 220 virtual float duration() const;
221 virtual float currentTime() const; 221 virtual float currentTime() const;
222 222
223 // Get rate of loading the resource. 223 // Get rate of loading the resource.
224 virtual int32 dataRate() const; 224 virtual int32 dataRate() const;
225 225
226 // Internal states of loading and network. 226 // Internal states of loading and network.
227 // TODO(hclam): Ask the pipeline about the state rather than having reading 227 // TODO(hclam): Ask the pipeline about the state rather than having reading
228 // them from members which would cause race conditions. 228 // them from members which would cause race conditions.
229 virtual WebKit::WebMediaPlayer::NetworkState networkState() const { 229 virtual WebKit::WebMediaPlayer::NetworkState networkState() const;
230 return network_state_; 230 virtual WebKit::WebMediaPlayer::ReadyState readyState() const;
231 }
232 virtual WebKit::WebMediaPlayer::ReadyState readyState() const {
233 return ready_state_;
234 }
235 231
236 virtual unsigned long long bytesLoaded() const; 232 virtual unsigned long long bytesLoaded() const;
237 virtual unsigned long long totalBytes() const; 233 virtual unsigned long long totalBytes() const;
238 234
239 virtual bool hasSingleSecurityOrigin() const; 235 virtual bool hasSingleSecurityOrigin() const;
240 virtual WebKit::WebMediaPlayer::MovieLoadType movieLoadType() const; 236 virtual WebKit::WebMediaPlayer::MovieLoadType movieLoadType() const;
241 237
242 virtual WebKit::WebVideoFrame* getCurrentFrame(); 238 virtual WebKit::WebVideoFrame* getCurrentFrame();
243 virtual void putCurrentFrame(WebKit::WebVideoFrame* web_video_frame); 239 virtual void putCurrentFrame(WebKit::WebVideoFrame* web_video_frame);
244 240
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 #if WEBKIT_USING_CG 316 #if WEBKIT_USING_CG
321 scoped_ptr<skia::PlatformCanvas> skia_canvas_; 317 scoped_ptr<skia::PlatformCanvas> skia_canvas_;
322 #endif 318 #endif
323 319
324 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl); 320 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
325 }; 321 };
326 322
327 } // namespace webkit_glue 323 } // namespace webkit_glue
328 324
329 #endif // WEBKIT_GLUE_WEBMEDIAPLAYER_IMPL_H_ 325 #endif // WEBKIT_GLUE_WEBMEDIAPLAYER_IMPL_H_
OLDNEW
« no previous file with comments | « webkit/glue/plugins/plugin_stream.cc ('k') | webkit/glue/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698