tools/tickprocessor.js - Issue 574015: Profiler tick processor: exploit d8's readline to avoid reading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/tickprocessor.js

Issue 574015: Profiler tick processor: exploit d8's readline to avoid reading (Closed)

Patch Set: Re-upload Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/tickprocessor.js

diff --git a/tools/tickprocessor.js b/tools/tickprocessor.js

index 73bdf354e44a6a9418fa6b7e0860ad0dae916d80..a40d95d29f6fababe6727dcf3a651ef3c15fbf2f 100644

--- a/tools/tickprocessor.js

+++ b/tools/tickprocessor.js

@@ -262,8 +262,10 @@ TickProcessor.prototype.isJsCode = function(name) {

TickProcessor.prototype.processLogFile = function(fileName) {

this.lastLogFileName_ = fileName;

- var contents = readFile(fileName);

- this.processLogChunk(contents);

+ var line;

+ while (line = readline()) {

+ this.processLogLine(line);

+ }

};

« no previous file with comments | « tools/logreader.js ('k') | tools/windows-tick-processor.bat » ('j') | no next file with comments »