Issue 574005: Fix issue 597: builtins and stubs are missing in profiler log when using snapshots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 574005: Fix issue 597: builtins and stubs are missing in profiler log when using snapshots. (Closed)

Created:
10 years, 10 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Fix issue 597: builtins and stubs are missing in profiler log when using snapshots. After this fix, profiles of non-snapshotted VMs are now equivalent to profiles of snapshotted VMs (having that --log-snapshot-positions is used, and mksnapshot's log is given to the tick processor script.) BUG=597 Committed: http://code.google.com/p/v8/source/detail?r=3802

Patch Set 1 #

Total comments: 2

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -2 lines)			Patch
M	src/log.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/log.cc	View	1 chunk	+10 lines, -0 lines	2 comments	Download
M	src/v8.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	tools/tickprocessor.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM. http://codereview.chromium.org/574005/diff/1/2 File src/log.cc (right): http://codereview.chromium.org/574005/diff/1/2#newcode1302 src/log.cc:1302: LogCodeObject(obj); Seems like if (obj->IsCode()) LogCodeObject(obj) would be ...

10 years, 10 months ago (2010-02-04 20:52:54 UTC) #2

mnaganov (inactive)

10 years, 10 months ago (2010-02-04 21:33:06 UTC) #3

http://codereview.chromium.org/574005/diff/1/2
File src/log.cc (right):

http://codereview.chromium.org/574005/diff/1/2#newcode1302
src/log.cc:1302: LogCodeObject(obj);
On 2010/02/04 20:52:54, Erik Corry wrote:
> Seems like
> if (obj->IsCode()) LogCodeObject(obj)
> would be more compact and easier to read.

Indeed. Fixed.

Expand Messages | Collapse Messages