Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 5739006: mac output cleanup script: fix match for "nothing to do" make output (Closed)

Created:
10 years ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

mac output cleanup script: fix match for "nothing to do" make output Shoulda written a test! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/sanitize-mac-build-log.sed View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
10 years ago (2010-12-13 21:51:04 UTC) #1
Mark Mentovai
LGTM :)
10 years ago (2010-12-13 22:00:04 UTC) #2
Scott Byer
10 years ago (2010-12-13 23:39:57 UTC) #3
Drive by: on 10.6 at least, sed is in /usr/bin, not /bin.

On 2010/12/13 22:00:04, Mark Mentovai wrote:
> LGTM :)

Powered by Google App Engine
This is Rietveld 408576698